refactor(rpc): add TxEnv converter to RpcCoverter#17792
Merged
mattsse merged 14 commits intoparadigmxyz:mainfrom Aug 26, 2025
Merged
refactor(rpc): add TxEnv converter to RpcCoverter#17792mattsse merged 14 commits intoparadigmxyz:mainfrom
TxEnv converter to RpcCoverter#17792mattsse merged 14 commits intoparadigmxyz:mainfrom
Conversation
lean-apple
changed the title
TxEnv converter to RpcCoverter
lean-apple
requested review from
Rjected,
RomanHodulak and
mattsse
as code owners
mattsse
requested changes
Aug 12, 2025
CodSpeed Performance ReportMerging #17792 will not alter performanceComparing Summary
|
mattsse
requested changes
Aug 14, 2025
Collaborator
mattsse
left a comment
mattsse
left a comment
There was a problem hiding this comment.
can we undo the function signature change
lean-apple
force-pushed
the
refactor-rpc-converter-tx-env
branch
from
ef54dcc to
4e6c9fd
Compare
mattsse
reviewed
Aug 19, 2025
Collaborator
mattsse
left a comment
mattsse
left a comment
There was a problem hiding this comment.
question about the closure impl
this doesnt seem useful because cfg<()> isnt a thing I believe?
klkvr
approved these changes
Aug 26, 2025
klkvr
reviewed
Aug 26, 2025
| /// | ||
| /// The `TxEnvConverter` has a blanket implementation: | ||
| /// * `()` assuming `TxReq` implements [`TryIntoTxEnv`] and is used as default for [`RpcConverter`]. | ||
| pub trait TxEnvConverter<TxReq, TxEnv>: Debug + Send + Sync + Unpin + Clone + 'static { |
Member
There was a problem hiding this comment.
can we add a blanket implementation for closures in scope of this PR?
Collaborator
There was a problem hiding this comment.
I don't think this works because this requires Spec generic,
should we make this an AT as well?
Member
There was a problem hiding this comment.
ah right
yeah we can make Spec an AT on RpcConvert, and do TxEnvConverter<TxReq, TxEnv, Spec>. we should know the spec type from the Evm
theochap
pushed a commit
to ethereum-optimism/optimism
that referenced
this pull request
Jan 22, 2026
…th#17792) Co-authored-by: Roman Hodulák <roman.hodulak@polyglot-software.com>
theochap
pushed a commit
to ethereum-optimism/optimism
that referenced
this pull request
Feb 11, 2026
…th#17792) Co-authored-by: Roman Hodulák <roman.hodulak@polyglot-software.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part 1 to go towards #17545.
Still to do:
Add convertion support only for
TxEnv, other conversions will be done in next prs.