feat(rpc): add configurable pending block behaviour#17677
Merged
mattsse merged 1 commit intoparadigmxyz:mainfrom Aug 15, 2025
Merged
feat(rpc): add configurable pending block behaviour#17677mattsse merged 1 commit intoparadigmxyz:mainfrom
mattsse merged 1 commit intoparadigmxyz:mainfrom
Conversation
shiyasmohd
requested review from
Rjected,
RomanHodulak,
klkvr,
mattsse and
onbjerg
as code owners
shiyasmohd
force-pushed
the
shiyasmohd/pending-block-behaviour
branch
4 times, most recently
from
6135054 to
d398855
Compare
shiyasmohd
force-pushed
the
shiyasmohd/pending-block-behaviour
branch
4 times, most recently
from
b156ab8 to
2d171ce
Compare
Contributor
Author
|
@mattsse Thanks for the review! I've pushed the changes. |
Contributor
Author
|
Following up here :) |
fix: formating & clippy feat: impl pending_block_config on optimism docs: add docs for pending-block flag fix: fix fmt docs: update description for pending-block flag fix: change PendingBlockConfig to PendingBlockKind
RomanHodulak
force-pushed
the
shiyasmohd/pending-block-behaviour
branch
from
2d171ce to
3d9658c
Compare
mattsse
approved these changes
Aug 15, 2025
Collaborator
mattsse
left a comment
mattsse
left a comment
There was a problem hiding this comment.
lgtm!
actually pretty straightforward,easy integration
Collaborator
|
@shiyasmohd sorry for the delay, we had to time this with another feature |
Contributor
Author
|
Thanks! |
lwedge99
pushed a commit
to sentioxyz/reth
that referenced
this pull request
Sep 16, 2025
theochap
pushed a commit
to ethereum-optimism/optimism
that referenced
this pull request
Jan 22, 2026
theochap
pushed a commit
to ethereum-optimism/optimism
that referenced
this pull request
Feb 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR solves the issue addressed here, where RPC was always building entire blocks with all transactions.
Changes
Add
--rpc.pending-blockCLI option to control pending block construction:empty: Return block header only, no transactionsnone: Return null/no pending blockfull: Include all transactions from mempool (default)Closes #17535
Let me know if any changes are required! Thanks!