feat(optimism): Add FlashBlockService that builds blocks from FlashBlocks#18009
Merged
RomanHodulak merged 9 commits intomainfrom Aug 25, 2025
Merged
feat(optimism): Add FlashBlockService that builds blocks from FlashBlocks#18009RomanHodulak merged 9 commits intomainfrom
FlashBlockService that builds blocks from FlashBlocks#18009RomanHodulak merged 9 commits intomainfrom
Conversation
RomanHodulak
requested review from
Rjected,
fgimenez,
gakonst,
mattsse and
rkrasiuk
as code owners
RomanHodulak
force-pushed
the
reth-flashblocks-service
branch
from
1e9a181 to
89d336a
Compare
mattsse
requested changes
Aug 22, 2025
Collaborator
mattsse
left a comment
mattsse
left a comment
There was a problem hiding this comment.
some suggestions but I like the direction
RomanHodulak
force-pushed
the
reth-flashblocks-service
branch
from
89d336a to
cd5b3ea
Compare
RomanHodulak
force-pushed
the
reth-flashblocks-service
branch
from
cd5b3ea to
8f38a1d
Compare
RomanHodulak
force-pushed
the
reth-flashblocks-service
branch
from
7330dba to
c0360b4
Compare
RomanHodulak
force-pushed
the
reth-flashblocks-service
branch
from
12565cd to
ca1219f
Compare
…pectation of proper sequencing of `FlashBlock`s
mattsse
requested changes
Aug 25, 2025
| match this.rx.poll_next_unpin(cx) { | ||
| Poll::Ready(Some(flashblock)) => this.add_flash_block(flashblock), | ||
| Poll::Ready(None) => return Poll::Ready(None), | ||
| Poll::Pending => return Poll::Ready(Some(this.execute())), |
Collaborator
There was a problem hiding this comment.
how this part will actually work we'll need to figure out we actually wire this to the rpc part, so make this doesn't need to be a stream entirely and could manage the pending block internally entirely
but we can figure this part out later
mattsse
added
A-rpc
RomanHodulak
force-pushed
the
reth-flashblocks-service
branch
from
943816d to
e9e3d22
Compare
RomanHodulak
force-pushed
the
reth-flashblocks-service
branch
from
6c0217d to
7289ccb
Compare
mattsse
approved these changes
Aug 25, 2025
Collaborator
mattsse
left a comment
mattsse
left a comment
There was a problem hiding this comment.
lgtm,
we can do fine tuning as followups
lwedge99
pushed a commit
to sentioxyz/reth
that referenced
this pull request
Sep 16, 2025
theochap
pushed a commit
to ethereum-optimism/optimism
that referenced
this pull request
Jan 22, 2026
theochap
pushed a commit
to ethereum-optimism/optimism
that referenced
this pull request
Feb 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #17858
Adds a service that receives
FlashBlocks and buildsExecutedBlocks.The
add_flash_blockpart of the implementation implements theFlashBlocks accumulation logic inspired by thebase/node-reth.