chore(op-reth): remove op-reth dependencies from core reth library crates#21492
Merged
mattsse merged 1 commit intoparadigmxyz:mainfrom Jan 28, 2026
Merged
chore(op-reth): remove op-reth dependencies from core reth library crates#21492mattsse merged 1 commit intoparadigmxyz:mainfrom
mattsse merged 1 commit intoparadigmxyz:mainfrom
Conversation
theochap
requested review from
Rjected,
gakonst,
joshieDo,
mattsse,
mediocregopher and
yongkangc
as code owners
theochap
commented
Jan 27, 2026
| /// <https://optimistic.etherscan.io/tx/0x312e290cf36df704a2217b015d6455396830b0ce678b860ebfcc30f41403d7b1> | ||
| pub const TX_SET_L1_BLOCK_OP_MAINNET_BLOCK_124665056: [u8; 251] = hex!( | ||
| "7ef8f8a0683079df94aa5b9cf86687d739a60a9b4f0835e520ec4d664e2e415dca17a6df94deaddeaddeaddeaddeaddeaddeaddeaddead00019442000000000000000000000000000000000000158080830f424080b8a4440a5e200000146b000f79c500000000000000040000000066d052e700000000013ad8a3000000000000000000000000000000000000000000000000000000003ef1278700000000000000000000000000000000000000000000000000000000000000012fdf87b89884a61e74b322bbcf60386f543bfae7827725efaaf0ab1de2294a590000000000000000000000006887246668a3b87f54deb3b94ba47a6f63f32985" | ||
| ); |
Contributor
Author
There was a problem hiding this comment.
No reason to keep that one around
theochap
commented
Jan 27, 2026
| } | ||
| .unwrap_or_default(); | ||
|
|
||
| Ok(OpTransactionInfo::new(tx_info, deposit_meta)) |
Contributor
Author
There was a problem hiding this comment.
I just inlined that method
theochap
commented
Jan 27, 2026
| impl TryFromTransactionResponse<op_alloy_network::Optimism> | ||
| for reth_optimism_primitives::OpTransactionSigned | ||
| { | ||
| impl TryFromTransactionResponse<op_alloy_network::Optimism> for op_alloy_consensus::OpTxEnvelope { |
Contributor
Author
There was a problem hiding this comment.
OpTxEnvelope is a type alias of OpTransactionSigned
This was referenced Jan 27, 2026
sebastianst
reviewed
Jan 28, 2026
Comment on lines
+75
to
+81
| /// Dummy system transaction for dev mode. | ||
| /// OP Mainnet transaction at index 0 in block 124665056. | ||
| /// | ||
| /// <https://optimistic.etherscan.io/tx/0x312e290cf36df704a2217b015d6455396830b0ce678b860ebfcc30f41403d7b1> | ||
| const TX_SET_L1_BLOCK_OP_MAINNET_BLOCK_124665056: [u8; 251] = alloy_primitives::hex!( | ||
| "7ef8f8a0683079df94aa5b9cf86687d739a60a9b4f0835e520ec4d664e2e415dca17a6df94deaddeaddeaddeaddeaddeaddeaddeaddead00019442000000000000000000000000000000000000158080830f424080b8a4440a5e200000146b000f79c500000000000000040000000066d052e700000000013ad8a3000000000000000000000000000000000000000000000000000000003ef1278700000000000000000000000000000000000000000000000000000000000000012fdf87b89884a61e74b322bbcf60386f543bfae7827725efaaf0ab1de2294a590000000000000000000000006887246668a3b87f54deb3b94ba47a6f63f32985" | ||
| ); |
Contributor
There was a problem hiding this comment.
what's the purpose of always setting this dummy deposit tx?
mattsse
approved these changes
Jan 28, 2026
theochap
added a commit
to ethereum-optimism/optimism
that referenced
this pull request
Jan 29, 2026
theochap
added a commit
to ethereum-optimism/optimism
that referenced
this pull request
Feb 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Should make progress towards ethereum-optimism/optimism#18916
Summary
Removes direct dependencies on
reth-optimism-primitives,reth-optimism-chainspec, andreth-storage-apifrom core reth library crates, replacing them with lighter upstreamop-alloy-consensustypes where needed. This reduces coupling between the base Ethereum client and the Optimism feature layer.This is possible because the
reth-optimism-primitivestypes used in these crates are thin wrappers overop-alloy-consensus:reth_optimism_primitives::OpReceiptis a re-export ofop_alloy_consensus::OpReceiptreth_optimism_primitives::OpTransactionSignedis a type alias forop_alloy_consensus::OpTxEnvelopeSince these are not distinct types, the affected crates can depend on
op-alloy-consensusdirectly instead of pulling inreth-optimism-primitives.Changes per crate
reth-rpc-convert: Removedreth-optimism-primitivesandreth-storage-apidependencies from theopfeature. Thetry_into_op_tx_infohelper (which requiredReceiptProviderandDepositReceiptfrom op-reth) is moved out of this crate; the logic is inlined intocrates/optimism/rpc/src/eth/transaction.rswhere the op-reth context is already available.TryFromTransactionResponseandTryFromReceiptResponseimpls now target theop-alloy-consensustypes directly (OpTxEnvelope,OpReceipt).reth-engine-local: Removedreth-optimism-chainspecdependency. TheTX_SET_L1_BLOCK_OP_MAINNET_BLOCK_124665056constant (only used in dev-mode payload building) is inlined as a localconstinstead of pulling in the entire optimism chainspec crate.reth-db-api: Replacedreth-optimism-primitiveswithop-alloy-consensusin theopfeature. Theimpl_compression_for_compact!invocations now referenceOpTxEnvelope/OpReceiptfromop-alloy-consensusdirectly.reth-optimism-chainspec: Removed the now-unusedTX_SET_L1_BLOCK_OP_MAINNET_BLOCK_124665056constant and itsheximport.Test plan
cargo +nightly clippy --workspace --all-features,cargo nextest run --workspace)opfeature gates still compile correctly across affected crates🤖 Generated partly with Claude Code