feat(rpc): Add support for custom Tokio runtime configuration in EthereumAddOns#17693
Merged
mattsse merged 9 commits intoparadigmxyz:mainfrom Aug 14, 2025
Merged
Conversation
Provides to ability to configure a node with custom Tokio runtime
mablr
force-pushed
the
feature/custom-tokio-rt-followup
branch
from
10bfa1d to
0ef6092
Compare
mattsse
requested changes
Jul 31, 2025
Collaborator
mattsse
left a comment
mattsse
left a comment
There was a problem hiding this comment.
great, we can also do this for opaddons
mattsse
approved these changes
Aug 14, 2025
Collaborator
mattsse
left a comment
mattsse
left a comment
There was a problem hiding this comment.
ty!
I made the functions accept an option this makes this slightly more ergonomic when dealing with this
Comment on lines
+77
to
+78
| // #[tokio::test] can not be used here because we need to create a custom tokio runtime | ||
| // and it would be dropped before the test is finished, resulting in a panic. |
Collaborator
There was a problem hiding this comment.
thanks for flagging this, I also added this to the addons fns
lwedge99
pushed a commit
to sentioxyz/reth
that referenced
this pull request
Sep 16, 2025
…reumAddOns (paradigmxyz#17693) Co-authored-by: Matthias Seitz <matthias.seitz@outlook.de>
theochap
pushed a commit
to ethereum-optimism/optimism
that referenced
this pull request
Jan 22, 2026
…reumAddOns (paradigmxyz/reth#17693) Co-authored-by: Matthias Seitz <matthias.seitz@outlook.de>
theochap
pushed a commit
to ethereum-optimism/optimism
that referenced
this pull request
Feb 11, 2026
…reumAddOns (paradigmxyz/reth#17693) Co-authored-by: Matthias Seitz <matthias.seitz@outlook.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Towards #17605 (follow-up for #17611)
This change bubbles up the
with_tokio_runtime()method from theRpcServerConfigtoEthereumAddOns, allowing to configure nodes with custom Tokio runtimes.The optional runtime handle is now passed through the
RpcAddOnsstructure and applied to RPC server configuration when provided.