fix(optimism): correct string formatting in error message#17923
Merged
mattsse merged 1 commit intoparadigmxyz:mainfrom Aug 19, 2025
Merged
fix(optimism): correct string formatting in error message#17923mattsse merged 1 commit intoparadigmxyz:mainfrom
mattsse merged 1 commit intoparadigmxyz:mainfrom
Conversation
The error message contains `{url}` but uses closure syntax
instead of proper string formatting. This will literally
print `{url}` instead of the actual URL value.
This fix uses `format!` macro to properly interpolate url.
bendanzhentan
requested review from
Rjected,
fgimenez and
mattsse
as code owners
mattsse
approved these changes
Aug 19, 2025
Collaborator
mattsse
left a comment
mattsse
left a comment
There was a problem hiding this comment.
ah, yes this should indeed be a format
lwedge99
pushed a commit
to sentioxyz/reth
that referenced
this pull request
Sep 16, 2025
theochap
pushed a commit
to ethereum-optimism/optimism
that referenced
this pull request
Jan 22, 2026
theochap
pushed a commit
to ethereum-optimism/optimism
that referenced
this pull request
Feb 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The error message contains
{url}but uses closure syntax instead of proper string formatting. This will literally print{url}instead of the actual URL value.This fix uses
format!macro to properly interpolate url.