eth/catalyst: update payload id computation [optimism bedrock]#1
Merged
mslipper merged 1 commit intooptimism-historyfrom Sep 9, 2022
Merged
eth/catalyst: update payload id computation [optimism bedrock]#1mslipper merged 1 commit intooptimism-historyfrom
mslipper merged 1 commit intooptimism-historyfrom
Conversation
protolambda
force-pushed
the
optimism-history
branch
from
4e1785b to
fdc9914
Compare
protolambda
force-pushed
the
payload-id
branch
from
a6d85da to
54eb808
Compare
mslipper
approved these changes
Sep 9, 2022
mdehoog
referenced
this pull request
in mdehoog/op-geth
Oct 10, 2022
Use minimal transaction format as block codec
protolambda
added a commit
that referenced
this pull request
Nov 4, 2022
protolambda
added a commit
that referenced
this pull request
Feb 22, 2023
This commit squashes the op-geth fork history into a more maintainable diff for rebasing upon upstream geth. reference-optimistic-geth changes (origins of op-geth in early Bedrock development stage): - Deposit TX Type - Enable deposit tx in EVM/tx pool - Change deposit nonce to not be the max nonce - Extend PayloadAttributesV1 with a Transactions field - Force deposits at the start of each L2 block - Fix height check - noTxPool flag, reproduce block in verifier mode without tx pool interference - Fix RPC json marshalling (ref op-geth PR 4) - Deposit txs block height check in block body validation (ref op-geth PR 5) - core: do not try to reinject deposit txs into tx-pool (ref-op-geth PR 6) - deposit source hash field instead of L2 block height and tx index combination - Include invalid deposits, rewind state, but always persist mint (#10) - Provide gas to Call/Create in deposit transactions (#12) - Add docker builds (ref-op-geth PR 16, 17) - Don't panic on deposit transaction signature values or chain ID (ref-op-geth PR 18) - core: Add version to DepositTx (ref-op-geth PR 19) - Enable Geth build/lint/test in CircleCI (ref-op-geth PR 23) - core: Include guaranteed gas in the gas pool (ref-op-geth PR 21) - core: handle base fee, l1 availability fee, tx fee (ref-op-geth PR 27) - fix: deposit tx hash - fix l1 fee cache, rpc, tracing and tx pool - core: remove deposit-tx sub-type (a.k.a. deposit version byte) - eth/catalyst: allow engine user to reorg own chain - miner: restore ability to reorg deep as block builder - params: print Optimism consensus type in banner - core/types: remove unused protected() method, see upstream PR 23376 - core: do not mutate original balance value in tx pool l1 cost adjustment - core: subtract deposit gas from pool, so other txs do not use the same gas. And fail tx processing if deposits reach gas limit - core/types: deposits do not tip, avoid basefee subtraction - Unmeter the L1 Attributes Transaction - miner: handle force tx errors as critical, clean up diff - ci: Switch branch - eth,miner: return STATUS_INVALID when failing to process forced transactions in request (ref-op-geth PR 40) - verifier: forward tx to sequencer based on flag - txpool: add flag to disable tx gossip (ref-op-geth PR 42) - Add op-geth version in addition to geth version (ref-op-geth PR 43) - ci: CircleCI improvements (ref-op-geth PR 44) - Rename to op-geth - Build latest tag on optimism branch op-geth changes: - Expose cache config in simulated backend (#2) - Add EIP-1559 parameters - eth/catalyst: update payload id computation (#1) - make eip1559 configurable (#4) - post-merge network should not log warnings about missing transition information (#5) - Make the simulator more configurable (#6) - fix OPB-6 - IsDepositTx check instead of artificial nonce value check (#7) - Simulated backend - enable proof of stake consensus type and fix performance issue (#8) - accounts: simulated backend consensus engine option and immediate tx indexing - consensus/beacon: recognize all blocks as reached TTD with 0 TTD in chain config - Add --rollup.historicalhttp CLI flag and fix backend iface - Flags and interfaces for historical RPC requests (#12) - Redirect historical RPC requests (#13) - Use the pre-existing ethereum.NotFound error (#18) - Add historical endpoint to TraceBlockByNumber and TraceBlockByHash (#19) - Add historical endpoint to TraceTransaction (#20) - Add historical endpoint to TraceCall (#21) - optimism: fee params from info txi, update l1 cost func GPO params read (#15) - add hardcoded addresses for fee payouts (#23) - dynamic gas limit via engine API (#22) Co-authored-by: Matthew Slipper <me@matthewslipper.com> Co-authored-by: Joshua Gutow <jgutow@oplabs.co> Co-authored-by: protolambda <proto@protolambda.com> Co-authored-by: Mark Tyneway <mark.tyneway@gmail.com> Co-authored-by: Maurelian <maurelian@protonmail.ch>
keroro520
pushed a commit
to keroro520/op-geth
that referenced
this pull request
Jul 28, 2023
…hereum-optimism#3) * ci: add docker release workflow to build and release docker image (ethereum-optimism#1) Co-authored-by: Welkin <welkin.b@nodereal.com> * try to use cache for docker build (ethereum-optimism#2) Co-authored-by: Welkin <welkin.b@nodereal.com> --------- Co-authored-by: Welkin <welkin.b@nodereal.com>
xiaoxiaff
pushed a commit
to xiaoxiaff/op-geth
that referenced
this pull request
Feb 8, 2024
[EIP-7212][test] Add wycheproof test vector
joey0612
pushed a commit
to joey0612/op-geth
that referenced
this pull request
Feb 20, 2024
) * feat: add precompiled contracts for Greenfield link * fix bug in lightclient * fix the comments * feature: add hardfork logic (ethereum-optimism#1) * feature: update hard fork info (ethereum-optimism#3) * Fix/fix dockerfile (ethereum-optimism#4) * fix: add libc-dev to support greenfield * feature: update devnet fork block number * feature: update chain config info (ethereum-optimism#5) --------- Co-authored-by: redhdx <136775144+redhdx@users.noreply.github.com>
riemannulus
pushed a commit
to riemannulus/op-geth
that referenced
this pull request
May 22, 2024
Add custom workflow for planetarium ghcr image
protolambda
pushed a commit
that referenced
this pull request
Aug 8, 2024
Merge op-geth changes to v1.14.7 branch
sebastianst
pushed a commit
that referenced
this pull request
Apr 4, 2025
…079) This PR is #1 of a 3-part series that implements the new log index intended to replace core/bloombits. Replaces ethereum/go-ethereum#30370 This part implements the new data structure, the log index generator and the search logic. This PR has most of the complexity but it does not affect any existing code yet so maybe it is easier to review separately. FilterMaps data structure explanation: https://gist.github.com/zsfelfoldi/a60795f9da7ae6422f28c7a34e02a07e Log index generator code overview: https://gist.github.com/zsfelfoldi/97105dff0b1a4f5ed557924a24b9b9e7 Search pattern matcher code overview: https://gist.github.com/zsfelfoldi/5981735641c956afb18065e84f8aff34 Note that the possibility of a tree hashing scheme and remote proof protocol are mentioned in the documents above but they are not exactly specified yet. These specs are WIP and will be finalized after the local log indexer/filter code is finalized and merged. --------- Co-authored-by: Felix Lange <fjl@twurst.com>
kchojn
referenced
this pull request
in compose-network/op-geth
Oct 14, 2025
* Add protobufs, client and SendRawXTransaction handler drafts * Add server, update backend * Add SP message handler * Fix shutdown, adjust xclient/main.go * Use separate client service for graceful reconnects to SP * Make shared publisher endpoints configurable * Forward only external transaction submissions * Aggregate logs * Add docker compose example * Add config.yml for xclient
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The chances of a collision here are very rare, as the payload ids are used in FIFO order, and one at a time, but it doesn't hurt to update the payload ID computation to match all payload attributes. Long-term these payload IDs may be used for other block building software.