Skip to content

config: Add historical-data rpc fallback#10

Merged
maurelian merged 1 commit intooptimism-historyfrom
cli/rollup-historicalhttp
Oct 18, 2022
Merged

config: Add historical-data rpc fallback#10
maurelian merged 1 commit intooptimism-historyfrom
cli/rollup-historicalhttp

Conversation

@maurelian
Copy link
Copy Markdown
Contributor

@maurelian maurelian commented Oct 14, 2022

Description

Adds a flag for specifying the rpc endpoint to query historical data.

#12 builds on this PR.

Metadata

  • Fixes ENG-2887

@protolambda
Copy link
Copy Markdown
Contributor

The PR description should highlight that this builds on top of #9, which is still in review.

@protolambda protolambda changed the title config: Add HistoricalTransitionBlock field config: Add historical-data rpc fallback Oct 15, 2022
Copy link
Copy Markdown
Contributor

@protolambda protolambda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR looks good, but I would prefer RPC instead of HTTP in the flag name. And we should review the PR it builds on top of, which introduces a config var which we may not need.

@maurelian
Copy link
Copy Markdown
Contributor Author

The PR description should highlight that this builds on top of #9, which is still in review.

Yes, and sorry I meant for this to be a draft actually.

@maurelian maurelian marked this pull request as draft October 16, 2022 00:01
@maurelian maurelian force-pushed the cli/rollup-historicalhttp branch 2 times, most recently from 99b8aa6 to 4b039de Compare October 17, 2022 15:23
@maurelian maurelian marked this pull request as ready for review October 17, 2022 15:40
@maurelian
Copy link
Copy Markdown
Contributor Author

Taking this out of review. Some changes:

  1. I've removed the commit which was included in config: Add HistoricalTransitionBlock field #9.
  2. I've change the naming from HTTP to RPC.

protolambda
protolambda previously approved these changes Oct 17, 2022
@protolambda protolambda self-requested a review October 17, 2022 23:59
@protolambda protolambda dismissed their stale review October 18, 2022 00:00

need to target optimism-history branch

@protolambda
Copy link
Copy Markdown
Contributor

Looks good, but need to target the optimism-history branch. The optimism branch is just a single squashed commit for sharing purposes.

@maurelian maurelian force-pushed the cli/rollup-historicalhttp branch 3 times, most recently from cd822c9 to 286d249 Compare October 18, 2022 15:36
@maurelian maurelian changed the base branch from optimism to optimism-history October 18, 2022 15:36
@maurelian
Copy link
Copy Markdown
Contributor Author

maurelian commented Oct 18, 2022

Looks good, but need to target the optimism-history branch. The optimism branch is just a single squashed commit for sharing purposes.

This PR now targets optimism-history.

@maurelian maurelian merged commit d9f5237 into optimism-history Oct 18, 2022
@maurelian maurelian deleted the cli/rollup-historicalhttp branch October 18, 2022 17:30
mmontour1306 pushed a commit to bobanetwork/v3-op-geth that referenced this pull request Oct 21, 2022
protolambda added a commit that referenced this pull request Feb 22, 2023
This commit squashes the op-geth fork history into a more maintainable
diff for rebasing upon upstream geth.

reference-optimistic-geth changes (origins of op-geth in early Bedrock
development stage):
- Deposit TX Type
- Enable deposit tx in EVM/tx pool
- Change deposit nonce to not be the max nonce
- Extend PayloadAttributesV1 with a Transactions field
- Force deposits at the start of each L2 block
- Fix height check
- noTxPool flag, reproduce block in verifier mode without tx pool interference
- Fix RPC json marshalling (ref op-geth PR 4)
- Deposit txs block height check in block body validation (ref op-geth PR 5)
- core: do not try to reinject deposit txs into tx-pool (ref-op-geth PR 6)
- deposit source hash field instead of L2 block height and tx index combination
- Include invalid deposits, rewind state, but always persist mint (#10)
- Provide gas to Call/Create in deposit transactions (#12)
- Add docker builds (ref-op-geth PR 16, 17)
- Don't panic on deposit transaction signature values or chain ID (ref-op-geth PR 18)
- core: Add version to DepositTx (ref-op-geth PR 19)
- Enable Geth build/lint/test in CircleCI (ref-op-geth PR 23)
- core: Include guaranteed gas in the gas pool (ref-op-geth PR 21)
- core: handle base fee, l1 availability fee, tx fee (ref-op-geth PR 27)
- fix: deposit tx hash
- fix l1 fee cache, rpc, tracing and tx pool
- core: remove deposit-tx sub-type (a.k.a. deposit version byte)
- eth/catalyst: allow engine user to reorg own chain
- miner: restore ability to reorg deep as block builder
- params: print Optimism consensus type in banner
- core/types: remove unused protected() method, see upstream PR 23376
- core: do not mutate original balance value in tx pool l1 cost adjustment
- core: subtract deposit gas from pool, so other txs do not use the same gas. And fail tx processing if deposits reach gas limit
- core/types: deposits do not tip, avoid basefee subtraction
- Unmeter the L1 Attributes Transaction
- miner: handle force tx errors as critical, clean up diff
- ci: Switch branch
- eth,miner: return STATUS_INVALID when failing to process forced transactions in request (ref-op-geth PR 40)
- verifier: forward tx to sequencer based on flag
- txpool: add flag to disable tx gossip (ref-op-geth PR 42)
- Add op-geth version in addition to geth version (ref-op-geth PR 43)
- ci: CircleCI improvements (ref-op-geth PR 44)
- Rename to op-geth
- Build latest tag on optimism branch

op-geth changes:
- Expose cache config in simulated backend (#2)
- Add EIP-1559 parameters
- eth/catalyst: update payload id computation (#1)
- make eip1559 configurable (#4)
- post-merge network should not log warnings about missing transition information (#5)
- Make the simulator more configurable (#6)
- fix OPB-6 - IsDepositTx check instead of artificial nonce value check (#7)
- Simulated backend - enable proof of stake consensus type and fix performance issue (#8)
- accounts: simulated backend consensus engine option and immediate tx indexing
- consensus/beacon: recognize all blocks as reached TTD with 0 TTD in chain config
- Add --rollup.historicalhttp CLI flag and fix backend iface
- Flags and interfaces for historical RPC requests (#12)
- Redirect historical RPC requests (#13)
- Use the pre-existing ethereum.NotFound error (#18)
- Add historical endpoint to TraceBlockByNumber and TraceBlockByHash (#19)
- Add historical endpoint to TraceTransaction (#20)
- Add historical endpoint to TraceCall (#21)
- optimism: fee params from info txi, update l1 cost func GPO params read (#15)
- add hardcoded addresses for fee payouts (#23)
- dynamic gas limit via engine API (#22)

Co-authored-by: Matthew Slipper <me@matthewslipper.com>
Co-authored-by: Joshua Gutow <jgutow@oplabs.co>
Co-authored-by: protolambda <proto@protolambda.com>
Co-authored-by: Mark Tyneway <mark.tyneway@gmail.com>
Co-authored-by: Maurelian <maurelian@protonmail.ch>
blockchaindevsh added a commit to blockchaindevsh/op-geth that referenced this pull request Oct 12, 2024
kangsorang pushed a commit to kroma-network/7560-geth that referenced this pull request Oct 15, 2024
emilianobonassi pushed a commit to emilianobonassi/op-geth that referenced this pull request Feb 7, 2025
…t-debugging

ensure parent's pointers are set before deferencing
blockchaindevsh added a commit to blockchaindevsh/op-geth that referenced this pull request Apr 28, 2025
kchojn referenced this pull request in compose-network/op-geth Oct 14, 2025
* Remove rollup-shared-publisher mention completelly

* Regenerate protobuf files for op-geth
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants