Redirect historical RPC requests

[maurelian]

Description

Updates the BlockChainAPI.Call() and BlockChainAPI.EstimateGas() methods so that they will attempt to fallback to calling the HistoricalRPCService in the event that the block is not found locally.

In order to handle this cleanly, a new error ErrHeaderNotFound was created.

Tests

New tests were added for both methods.

[trianglesphere]

Whats the plan for other requests like balance at & proofs? (Realistically also for any RPC that takes a block number)

[mslipper]

@trianglesphere the database will still contain historical block bodies and headers, so we only need the RPCs that include execution.

[trianglesphere]

the database will still contain historical block bodies and headers, so we only need the RPCs that include execution.

getBalanceAt doesn't do execution but relies on historical state in MPT. Will archive bedrock EE clients contain the full historical state as well?

[maurelian]

@trianglesphere I'd like to use this PR for validation of the approach and then expand to other methods.

Here is a list of methods I think do/do not require history, would appreciate a sanity check on them (only methods that take a blockNrOrHash argument are included):

// **Needs History**

func (s *BlockChainAPI) GetBalance(ctx context.Context, address common.Address, blockNrOrHash rpc.BlockNumberOrHash) (*hexutil.Big, error) {
func (s *BlockChainAPI) GetProof(ctx context.Context, address common.Address, storageKeys []string, blockNrOrHash rpc.BlockNumberOrHash) (*AccountResult, error) {
func (s *BlockChainAPI) GetUncleByBlockNumberAndIndex(ctx context.Context, blockNr rpc.BlockNumber, index hexutil.Uint) (map[string]interface{}, error) {
func (s *BlockChainAPI) GetUncleCountByBlockNumber(ctx context.Context, blockNr rpc.BlockNumber) *hexutil.Uint {
func (s *BlockChainAPI) GetCode(ctx context.Context, address common.Address, blockNrOrHash rpc.BlockNumberOrHash) (hexutil.Bytes, error) {
func (s *BlockChainAPI) GetStorageAt(ctx context.Context, address common.Address, key string, blockNrOrHash rpc.BlockNumberOrHash) (hexutil.Bytes, error) {
func (s *BlockChainAPI) Call(ctx context.Context, args TransactionArgs, blockNrOrHash rpc.BlockNumberOrHash, overrides *StateOverride) (hexutil.Bytes, error) {
func (s *BlockChainAPI) EstimateGas(ctx context.Context, args TransactionArgs, blockNrOrHash *rpc.BlockNumberOrHash) (hexutil.Uint64, error) {
func (s *BlockChainAPI) CreateAccessList(ctx context.Context, args TransactionArgs, blockNrOrHash *rpc.BlockNumberOrHash) (*accessListResult, error) {


// **Does not need history**
func (s *TransactionAPI) GetBlockTransactionCountByNumber(ctx context.Context, blockNr rpc.BlockNumber) *hexutil.Uint {
func (s *TransactionAPI) GetTransactionByBlockNumberAndIndex(ctx context.Context, blockNr rpc.BlockNumber, index hexutil.Uint) *RPCTransaction {
func (s *TransactionAPI) GetRawTransactionByBlockNumberAndIndex(ctx context.Context, blockNr rpc.BlockNumber, index hexutil.Uint) hexutil.Bytes {
func (s *TransactionAPI) GetTransactionCount(ctx context.Context, address common.Address, blockNrOrHash rpc.BlockNumberOrHash) (*hexutil.Uint64, error) {


func (api *DebugAPI) GetRawHeader(ctx context.Context, blockNrOrHash rpc.BlockNumberOrHash) (hexutil.Bytes, error) {
func (api *DebugAPI) GetRawBlock(ctx context.Context, blockNrOrHash rpc.BlockNumberOrHash) (hexutil.Bytes, error) {
func (api *DebugAPI) GetRawReceipts(ctx context.Context, blockNrOrHash rpc.BlockNumberOrHash) ([]hexutil.Bytes, error) {

[trianglesphere]

The plan sounds good (gonna need more linear tickets though).

I agree with the skips. For the historical ones, I think we might be able to skip the access list one for historical state. I'd also want to double check that we need to load state (rather than the block bodies) for the uncles one.

I'd also want to cross check this against the eth API specs / list of js functions to make sure it's exhaustive.

[trianglesphere]

lgtm. Follow up steps are to extend this to other historical RPC tests + get a devnet like (maybe hive, not sure yet) to start exercising these codepaths in CI.