Skip to content

[EIP-7212][test] Add wycheproof test vector#1

Merged
mdehoog merged 1 commit intomdehoog:ulerdogan-secp256r1from
xiaoxiaff:ytu/tv
Feb 8, 2024
Merged

[EIP-7212][test] Add wycheproof test vector#1
mdehoog merged 1 commit intomdehoog:ulerdogan-secp256r1from
xiaoxiaff:ytu/tv

Conversation

@xiaoxiaff
Copy link

@xiaoxiaff xiaoxiaff commented Feb 8, 2024

Adding secp256r1 test vector. It is based on Google's wycheproof test vectors, which covers both happy path and failure cases.

It also uses the same test vectors as p256-verifier.

Copy link

@ulerdogan ulerdogan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on my local, i think that it works successfully! Thanks for improving the test cases.

Copy link
Owner

@mdehoog mdehoog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

amazing thank you!

@mdehoog mdehoog merged commit d456a35 into mdehoog:ulerdogan-secp256r1 Feb 8, 2024
mdehoog added a commit that referenced this pull request Feb 8, 2024
[EIP-7212][test] Add wycheproof test vector
mdehoog pushed a commit that referenced this pull request Aug 7, 2024
Merge op-geth changes to v1.14.7 branch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants