Skip to content

optimism: dynamic gas limit - engine API extension#22

Merged
protolambda merged 1 commit intooptimism-historyfrom
dynamic-gas-limit
Nov 4, 2022
Merged

optimism: dynamic gas limit - engine API extension#22
protolambda merged 1 commit intooptimism-historyfrom
dynamic-gas-limit

Conversation

@protolambda
Copy link
Copy Markdown
Contributor

@protolambda protolambda commented Oct 28, 2022 •
edited
Loading

PR changes:

  • Allow gas limit to instantly change when optimism config is active, instead of the 1/1024 adjustment factor that L1 uses.
  • Add optional gaslimit field to payload attributes
  • Add optional gaslimit field to internal block building parameters
  • Override gaslimit in template header if block building params has gaslimit
  • Check if gaslimit field is present in payload attributes if optimism config is active

Testing through monorepo e2e tests.

This enables the op-node to change the gaslimit based on block derivation.

@protolambda protolambda mentioned this pull request Oct 28, 2022
Merged
@protolambda protolambda marked this pull request as ready for review November 3, 2022 15:15
@protolambda protolambda changed the base branch from l1cost-api-fix to optimism-history November 4, 2022 12:46
mslipper
mslipper approved these changes Nov 4, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@mslipper mslipper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, but would like review from @trianglesphere as well to be sure.

@protolambda protolambda mentioned this pull request Nov 4, 2022
Merged
@tynes tynes requested review from trianglesphere and tynes November 4, 2022 15:46
tynes
tynes reviewed Nov 4, 2022
View reviewed changes
tynes
tynes approved these changes Nov 4, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@tynes tynes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

trianglesphere
trianglesphere approved these changes Nov 4, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@trianglesphere trianglesphere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@protolambda protolambda merged commit 9a6cc90 into optimism-history Nov 4, 2022
protolambda added a commit that referenced this pull request Nov 4, 2022
@protolambda
optimism: dynamic gas limit (#22)
c1e9b38
protolambda added a commit that referenced this pull request Feb 22, 2023
@trianglesphere @mslipper
@protolambda @tynes @maurelian
optimism: historical Bedrock geth rollup changes
c48b8aa 
This commit squashes the op-geth fork history into a more maintainable
diff for rebasing upon upstream geth.

reference-optimistic-geth changes (origins of op-geth in early Bedrock
development stage):
- Deposit TX Type
- Enable deposit tx in EVM/tx pool
- Change deposit nonce to not be the max nonce
- Extend PayloadAttributesV1 with a Transactions field
- Force deposits at the start of each L2 block
- Fix height check
- noTxPool flag, reproduce block in verifier mode without tx pool interference
- Fix RPC json marshalling (ref op-geth PR 4)
- Deposit txs block height check in block body validation (ref op-geth PR 5)
- core: do not try to reinject deposit txs into tx-pool (ref-op-geth PR 6)
- deposit source hash field instead of L2 block height and tx index combination
- Include invalid deposits, rewind state, but always persist mint (#10)
- Provide gas to Call/Create in deposit transactions (#12)
- Add docker builds (ref-op-geth PR 16, 17)
- Don't panic on deposit transaction signature values or chain ID (ref-op-geth PR 18)
- core: Add version to DepositTx (ref-op-geth PR 19)
- Enable Geth build/lint/test in CircleCI (ref-op-geth PR 23)
- core: Include guaranteed gas in the gas pool (ref-op-geth PR 21)
- core: handle base fee, l1 availability fee, tx fee (ref-op-geth PR 27)
- fix: deposit tx hash
- fix l1 fee cache, rpc, tracing and tx pool
- core: remove deposit-tx sub-type (a.k.a. deposit version byte)
- eth/catalyst: allow engine user to reorg own chain
- miner: restore ability to reorg deep as block builder
- params: print Optimism consensus type in banner
- core/types: remove unused protected() method, see upstream PR 23376
- core: do not mutate original balance value in tx pool l1 cost adjustment
- core: subtract deposit gas from pool, so other txs do not use the same gas. And fail tx processing if deposits reach gas limit
- core/types: deposits do not tip, avoid basefee subtraction
- Unmeter the L1 Attributes Transaction
- miner: handle force tx errors as critical, clean up diff
- ci: Switch branch
- eth,miner: return STATUS_INVALID when failing to process forced transactions in request (ref-op-geth PR 40)
- verifier: forward tx to sequencer based on flag
- txpool: add flag to disable tx gossip (ref-op-geth PR 42)
- Add op-geth version in addition to geth version (ref-op-geth PR 43)
- ci: CircleCI improvements (ref-op-geth PR 44)
- Rename to op-geth
- Build latest tag on optimism branch

op-geth changes:
- Expose cache config in simulated backend (#2)
- Add EIP-1559 parameters
- eth/catalyst: update payload id computation (#1)
- make eip1559 configurable (#4)
- post-merge network should not log warnings about missing transition information (#5)
- Make the simulator more configurable (#6)
- fix OPB-6 - IsDepositTx check instead of artificial nonce value check (#7)
- Simulated backend - enable proof of stake consensus type and fix performance issue (#8)
- accounts: simulated backend consensus engine option and immediate tx indexing
- consensus/beacon: recognize all blocks as reached TTD with 0 TTD in chain config
- Add --rollup.historicalhttp CLI flag and fix backend iface
- Flags and interfaces for historical RPC requests (#12)
- Redirect historical RPC requests (#13)
- Use the pre-existing ethereum.NotFound error (#18)
- Add historical endpoint to TraceBlockByNumber and TraceBlockByHash (#19)
- Add historical endpoint to TraceTransaction (#20)
- Add historical endpoint to TraceCall (#21)
- optimism: fee params from info txi, update l1 cost func GPO params read (#15)
- add hardcoded addresses for fee payouts (#23)
- dynamic gas limit via engine API (#22)

Co-authored-by: Matthew Slipper <me@matthewslipper.com>
Co-authored-by: Joshua Gutow <jgutow@oplabs.co>
Co-authored-by: protolambda <proto@protolambda.com>
Co-authored-by: Mark Tyneway <mark.tyneway@gmail.com>
Co-authored-by: Maurelian <maurelian@protonmail.ch>
joey0612 pushed a commit to joey0612/op-geth that referenced this pull request Feb 20, 2024
@welkin22 @owen-reorg
fix: remove unnecessary newRPCTransactionFromBlockHash function (ethe…
0eb8a65 
…reum-optimism#22)

Co-authored-by: Welkin <welkin.b@nodereal.com>
Co-authored-by: Owen <103096885+owen-reorg@users.noreply.github.com>
kangsorang pushed a commit to kroma-network/7560-geth that referenced this pull request Oct 15, 2024
@forshtat
AA-257: Return useful errors and on-chain revert reasons to the RPC r…
d8ab4eb 
…esponse message (ethereum-optimism#22)

* Propagate validation on-chain revert reasons to the RPC response message
* Explicit error for missing both deployed code and factory
* Bubble up the real 'RevertReason' through the 'TraceRip7560Validation' API
blockchaindevsh added a commit to blockchaindevsh/op-geth that referenced this pull request Jan 25, 2025
@blockchaindevsh
mod default value of RPCTxFeeCap (ethereum-optimism#22)
326349f 
* mod default value of RPCTxFeeCap

* update comment
geoknee pushed a commit that referenced this pull request Aug 29, 2025
@wlawt
Merge pull request #22 from wlawt/u64-approach
00d5079 
Use u64 approach
blockchaindevsh added a commit to blockchaindevsh/op-geth that referenced this pull request Oct 8, 2025
@blockchaindevsh
panic if both pools are nil (ethereum-optimism#22)
7ea0a22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tynes tynes tynes approved these changes

+2 more reviewers

@mslipper mslipper mslipper approved these changes

@trianglesphere trianglesphere trianglesphere approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@protolambda @mslipper @tynes @trianglesphere