op-geth: add hardcoded addresses for fee payouts#23
Merged
Conversation
Reduce the amount of consensus critical config by hardcoding the addresses that fees pay out to. The final recipient of the fees can now be controlled at the application layer, by the admin of the proxy sitting at the addresses that fees are paid out to.
protolambda
approved these changes
Oct 31, 2022
mslipper
approved these changes
Oct 31, 2022
trianglesphere
approved these changes
Nov 1, 2022
Contributor
trianglesphere
left a comment
trianglesphere
left a comment
There was a problem hiding this comment.
lgtm
Q - should we hardcode the coinable as well?
Contributor
Author
Right now that is hardcoded in the |
Contributor
Author
|
What is the process of merging and updating deps with this repo? Would like to merge this and then update the monorepo to use the new commit |
Contributor
Generally this repo is done first. Then there is a script in the monorepo to update the version |
tynes
added a commit
to ethereum-optimism/optimism
that referenced
this pull request
Nov 3, 2022
Includes ethereum-optimism/op-geth#23 Pulling these changes into the monorepo so that things can be integrated with `op-e2e`
mslipper
pushed a commit
that referenced
this pull request
Nov 4, 2022
Reduce the amount of consensus critical config by hardcoding the addresses that fees pay out to. The final recipient of the fees can now be controlled at the application layer, by the admin of the proxy sitting at the addresses that fees are paid out to.
protolambda
pushed a commit
that referenced
this pull request
Nov 4, 2022
Note that caching is not enabled because the circle ci recommended caching solution does not work with how geth does it builds (through the build/ci.go script).
protolambda
pushed a commit
that referenced
this pull request
Nov 4, 2022
Reduce the amount of consensus critical config by hardcoding the addresses that fees pay out to. The final recipient of the fees can now be controlled at the application layer, by the admin of the proxy sitting at the addresses that fees are paid out to.
protolambda
added a commit
that referenced
this pull request
Feb 22, 2023
This commit squashes the op-geth fork history into a more maintainable diff for rebasing upon upstream geth. reference-optimistic-geth changes (origins of op-geth in early Bedrock development stage): - Deposit TX Type - Enable deposit tx in EVM/tx pool - Change deposit nonce to not be the max nonce - Extend PayloadAttributesV1 with a Transactions field - Force deposits at the start of each L2 block - Fix height check - noTxPool flag, reproduce block in verifier mode without tx pool interference - Fix RPC json marshalling (ref op-geth PR 4) - Deposit txs block height check in block body validation (ref op-geth PR 5) - core: do not try to reinject deposit txs into tx-pool (ref-op-geth PR 6) - deposit source hash field instead of L2 block height and tx index combination - Include invalid deposits, rewind state, but always persist mint (#10) - Provide gas to Call/Create in deposit transactions (#12) - Add docker builds (ref-op-geth PR 16, 17) - Don't panic on deposit transaction signature values or chain ID (ref-op-geth PR 18) - core: Add version to DepositTx (ref-op-geth PR 19) - Enable Geth build/lint/test in CircleCI (ref-op-geth PR 23) - core: Include guaranteed gas in the gas pool (ref-op-geth PR 21) - core: handle base fee, l1 availability fee, tx fee (ref-op-geth PR 27) - fix: deposit tx hash - fix l1 fee cache, rpc, tracing and tx pool - core: remove deposit-tx sub-type (a.k.a. deposit version byte) - eth/catalyst: allow engine user to reorg own chain - miner: restore ability to reorg deep as block builder - params: print Optimism consensus type in banner - core/types: remove unused protected() method, see upstream PR 23376 - core: do not mutate original balance value in tx pool l1 cost adjustment - core: subtract deposit gas from pool, so other txs do not use the same gas. And fail tx processing if deposits reach gas limit - core/types: deposits do not tip, avoid basefee subtraction - Unmeter the L1 Attributes Transaction - miner: handle force tx errors as critical, clean up diff - ci: Switch branch - eth,miner: return STATUS_INVALID when failing to process forced transactions in request (ref-op-geth PR 40) - verifier: forward tx to sequencer based on flag - txpool: add flag to disable tx gossip (ref-op-geth PR 42) - Add op-geth version in addition to geth version (ref-op-geth PR 43) - ci: CircleCI improvements (ref-op-geth PR 44) - Rename to op-geth - Build latest tag on optimism branch op-geth changes: - Expose cache config in simulated backend (#2) - Add EIP-1559 parameters - eth/catalyst: update payload id computation (#1) - make eip1559 configurable (#4) - post-merge network should not log warnings about missing transition information (#5) - Make the simulator more configurable (#6) - fix OPB-6 - IsDepositTx check instead of artificial nonce value check (#7) - Simulated backend - enable proof of stake consensus type and fix performance issue (#8) - accounts: simulated backend consensus engine option and immediate tx indexing - consensus/beacon: recognize all blocks as reached TTD with 0 TTD in chain config - Add --rollup.historicalhttp CLI flag and fix backend iface - Flags and interfaces for historical RPC requests (#12) - Redirect historical RPC requests (#13) - Use the pre-existing ethereum.NotFound error (#18) - Add historical endpoint to TraceBlockByNumber and TraceBlockByHash (#19) - Add historical endpoint to TraceTransaction (#20) - Add historical endpoint to TraceCall (#21) - optimism: fee params from info txi, update l1 cost func GPO params read (#15) - add hardcoded addresses for fee payouts (#23) - dynamic gas limit via engine API (#22) Co-authored-by: Matthew Slipper <me@matthewslipper.com> Co-authored-by: Joshua Gutow <jgutow@oplabs.co> Co-authored-by: protolambda <proto@protolambda.com> Co-authored-by: Mark Tyneway <mark.tyneway@gmail.com> Co-authored-by: Maurelian <maurelian@protonmail.ch>
kangsorang
pushed a commit
to kroma-network/7560-geth
that referenced
this pull request
Oct 15, 2024
…ptance' (ethereum-optimism#23) * AA-411: Parse calls to EntryPoint address for account/paymaster 'acceptance' * Extract ABI encoding&decoding into file; use ABI instead of manual bit parsing * Remove rudimentary mentions of "magic" in RIP-7560 related code * Copy the "evm.Config.Tracer" instead of overriding the original object * Remove depth check, compare addresses instead
blockchaindevsh
added a commit
to blockchaindevsh/op-geth
that referenced
this pull request
Jan 25, 2025
* fix nil pointer * add comment * address comments
kchojn
referenced
this pull request
in compose-network/op-geth
Oct 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Reduce the amount of consensus critical config by hardcoding the addresses that fees pay out to. The final recipient of the fees can now be controlled at the application layer, by the admin of the proxy sitting at the addresses that fees are paid out to.