Skip to content

Add historical endpoint to TraceBlockByNumber and TraceBlockByHash#19

Merged
mslipper merged 4 commits intooptimism-historyfrom
history/tracers
Oct 28, 2022
Merged

Add historical endpoint to TraceBlockByNumber and TraceBlockByHash#19
mslipper merged 4 commits intooptimism-historyfrom
history/tracers

Conversation

@maurelian
Copy link
Copy Markdown
Contributor

Description

Adds fallback to the Historical RPC endpoint to

  • debug_traceBlockByNumber
  • debug_traceBlockByHash

Tests

A test was added for the historical case of debug_traceBlockByNumber. No tests yet exist for debug_traceBlockByHash, so they will be added in op-e2e instead.

Copy link
Copy Markdown
Contributor

@protolambda protolambda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Some minor nits, the ErrHeaderNotFound change might be worth trying before merging.

@maurelian maurelian changed the title Use the pre-existing ethereum.NotFound error Add historical endpoint to TraceBlockByNumber and TraceBlockByHash Oct 27, 2022
@mslipper mslipper merged commit 68b97bc into optimism-history Oct 28, 2022
protolambda pushed a commit that referenced this pull request Nov 4, 2022
This adds a second byte after the EIP-2718 Type byte to deposit
transactions that versions the deposit. It is placed prior to the start
of the RLP to make it easier to extend the transaction in the future. We
choose to version inside the EIP-2718 envelope to limit the number of
EIP-2718 prefixes we take for deposit transactions.
protolambda pushed a commit that referenced this pull request Nov 4, 2022
* Update test suite to add historical rpc

* Update tests to handle ethereum.NotFound

* Redefine ethApi.ErrHeaderNotFound to wrap ethereum.NotFound

* update error matcher

Co-authored-by: Matthew Slipper <me@matthewslipper.com>
protolambda added a commit that referenced this pull request Feb 22, 2023
This commit squashes the op-geth fork history into a more maintainable
diff for rebasing upon upstream geth.

reference-optimistic-geth changes (origins of op-geth in early Bedrock
development stage):
- Deposit TX Type
- Enable deposit tx in EVM/tx pool
- Change deposit nonce to not be the max nonce
- Extend PayloadAttributesV1 with a Transactions field
- Force deposits at the start of each L2 block
- Fix height check
- noTxPool flag, reproduce block in verifier mode without tx pool interference
- Fix RPC json marshalling (ref op-geth PR 4)
- Deposit txs block height check in block body validation (ref op-geth PR 5)
- core: do not try to reinject deposit txs into tx-pool (ref-op-geth PR 6)
- deposit source hash field instead of L2 block height and tx index combination
- Include invalid deposits, rewind state, but always persist mint (#10)
- Provide gas to Call/Create in deposit transactions (#12)
- Add docker builds (ref-op-geth PR 16, 17)
- Don't panic on deposit transaction signature values or chain ID (ref-op-geth PR 18)
- core: Add version to DepositTx (ref-op-geth PR 19)
- Enable Geth build/lint/test in CircleCI (ref-op-geth PR 23)
- core: Include guaranteed gas in the gas pool (ref-op-geth PR 21)
- core: handle base fee, l1 availability fee, tx fee (ref-op-geth PR 27)
- fix: deposit tx hash
- fix l1 fee cache, rpc, tracing and tx pool
- core: remove deposit-tx sub-type (a.k.a. deposit version byte)
- eth/catalyst: allow engine user to reorg own chain
- miner: restore ability to reorg deep as block builder
- params: print Optimism consensus type in banner
- core/types: remove unused protected() method, see upstream PR 23376
- core: do not mutate original balance value in tx pool l1 cost adjustment
- core: subtract deposit gas from pool, so other txs do not use the same gas. And fail tx processing if deposits reach gas limit
- core/types: deposits do not tip, avoid basefee subtraction
- Unmeter the L1 Attributes Transaction
- miner: handle force tx errors as critical, clean up diff
- ci: Switch branch
- eth,miner: return STATUS_INVALID when failing to process forced transactions in request (ref-op-geth PR 40)
- verifier: forward tx to sequencer based on flag
- txpool: add flag to disable tx gossip (ref-op-geth PR 42)
- Add op-geth version in addition to geth version (ref-op-geth PR 43)
- ci: CircleCI improvements (ref-op-geth PR 44)
- Rename to op-geth
- Build latest tag on optimism branch

op-geth changes:
- Expose cache config in simulated backend (#2)
- Add EIP-1559 parameters
- eth/catalyst: update payload id computation (#1)
- make eip1559 configurable (#4)
- post-merge network should not log warnings about missing transition information (#5)
- Make the simulator more configurable (#6)
- fix OPB-6 - IsDepositTx check instead of artificial nonce value check (#7)
- Simulated backend - enable proof of stake consensus type and fix performance issue (#8)
- accounts: simulated backend consensus engine option and immediate tx indexing
- consensus/beacon: recognize all blocks as reached TTD with 0 TTD in chain config
- Add --rollup.historicalhttp CLI flag and fix backend iface
- Flags and interfaces for historical RPC requests (#12)
- Redirect historical RPC requests (#13)
- Use the pre-existing ethereum.NotFound error (#18)
- Add historical endpoint to TraceBlockByNumber and TraceBlockByHash (#19)
- Add historical endpoint to TraceTransaction (#20)
- Add historical endpoint to TraceCall (#21)
- optimism: fee params from info txi, update l1 cost func GPO params read (#15)
- add hardcoded addresses for fee payouts (#23)
- dynamic gas limit via engine API (#22)

Co-authored-by: Matthew Slipper <me@matthewslipper.com>
Co-authored-by: Joshua Gutow <jgutow@oplabs.co>
Co-authored-by: protolambda <proto@protolambda.com>
Co-authored-by: Mark Tyneway <mark.tyneway@gmail.com>
Co-authored-by: Maurelian <maurelian@protonmail.ch>
joey0612 pushed a commit to joey0612/op-geth that referenced this pull request Feb 20, 2024
Co-authored-by: Welkin <welkin.b@nodereal.com>
Co-authored-by: Owen <103096885+owen-reorg@users.noreply.github.com>
kangsorang pushed a commit to kroma-network/7560-geth that referenced this pull request Oct 15, 2024
blockchaindevsh added a commit to blockchaindevsh/op-geth that referenced this pull request Oct 8, 2025
kchojn referenced this pull request in compose-network/op-geth Oct 14, 2025
* Update mailbox abi and mailbox simulator

* Update mailbox abi and mailbox simulator
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants