Merged
Conversation
spalger
force-pushed
the
fix/apply-settings-in-console
branch
from
0977de6 to
fb6d101
Compare
Contributor
|
@spalger This needs to be rebased |
spalger
force-pushed
the
fix/apply-settings-in-console
branch
from
fb6d101 to
c5b8c66
Compare
Contributor
Contributor
|
LGTM this fixes both the errors associated with ES6 import issue. settings get applied as well. |
spalger
force-pushed
the
fix/apply-settings-in-console
branch
from
c5b8c66 to
b728203
Compare
Contributor
|
@spalger conflicts |
Contributor
Author
|
Ugh |
added 2 commits
September 22, 2016 08:47
When splitting the input/output modules into an `initializeInput` and `getInput` pair, it was changed to an esModule. This means that you can no longer require is and execute it's default export directly, as was being done in the console's settings module.
spalger
force-pushed
the
fix/apply-settings-in-console
branch
from
b728203 to
752c333
Compare
Contributor
|
@spalger Can you make sure this gets backported to 5.x/5.0? |
elastic-jasper
added a commit
that referenced
this pull request
Sep 28, 2016
--------- **Commit 1:** [console] fix references to getInput function When splitting the input/output modules into an `initializeInput` and `getInput` pair, it was changed to an esModule. This means that you can no longer require is and execute it's default export directly, as was being done in the console's settings module. * Original sha: 086a40c * Authored by spalger <email@spalger.com> on 2016-09-19T20:18:27Z **Commit 2:** [console] add functional tests to ensure that settings work * Original sha: 752c333 * Authored by spalger <email@spalger.com> on 2016-09-19T20:23:07Z
spalger
pushed a commit
to spalger/kibana
that referenced
this pull request
Sep 30, 2016
[console] fix references to getInput function When splitting the input/output modules into an `initializeInput` and `getInput` pair, it was changed to an esModule. This means that you can no longer require is and execute it's default export directly, as was being done in the console's settings module. (cherry picked from commit 086a40c)
spalger
pushed a commit
to spalger/kibana
that referenced
this pull request
Sep 30, 2016
[console] fix references to getInput function When splitting the input/output modules into an `initializeInput` and `getInput` pair, it was changed to an esModule. This means that you can no longer require is and execute it's default export directly, as was being done in the console's settings module. (cherry picked from commit 086a40c)
airow
pushed a commit
to airow/kibana
that referenced
this pull request
Feb 16, 2017
[console] fix references to getInput function When splitting the input/output modules into an `initializeInput` and `getInput` pair, it was changed to an esModule. This means that you can no longer require is and execute it's default export directly, as was being done in the console's settings module. (cherry picked from commit 4952427302c8d64e0bf45a4f1f6e6cb8cea56f0c [formerly 086a40c]) Former-commit-id: a0dc55e
tkajtoch
added a commit
that referenced
this pull request
Mar 7, 2025
# Backport This is a manual backport of #212974 and #213292 --- `99.3.0-classic.0` ⏩ `100.0.0-classic.0` [Questions? Please see our Kibana upgrade FAQ.](https://github.com/elastic/eui/blob/main/wiki/eui-team-processes/upgrading-kibana.md#faq-for-kibana-teams) --- ## [`v100.0.0`](https://github.com/elastic/eui/releases/v100.0.0) **Bug fixes** - Fixed `EuiComboBox` by cleaning duplicated values when having a delimiter prop. ([#8335](elastic/eui#8335)) ## [`v99.4.0`](https://github.com/elastic/eui/releases/v99.4.0) - Minor design updates to `EuiCollapsibleNavBeta` ([#8332](elastic/eui#8332)) - Allow section without a title - Second-level icons should be horizontally aligned with the top-level icon - Turn off text truncation for nav items - Added `quickSelectButtonProps` to `EuiSuperDatePicker` ([#8380](elastic/eui#8380)) **Bug fixes** - Fixed a bug in `EuiHeader` where the navigation of `EuiCollapsibleNavBeta` would render below the `EuiFlyout`'s overlay ([#8325](elastic/eui#8325)) **Accessibility** - Improved the accessibility of `EuiComboBox` by adding `aria-setsize` and `aria-posinset` to ensure correct information is provided for its virtualized listbox ([#8333](elastic/eui#8333)) - Improved the `EuiAccordionTrigger`'s screen reader UX by passed `aria-hidden` to the `EuiAccordionArrow` to avoid duplicated announcements by screen readers. ([#8342](elastic/eui#8342)) --------- Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the settings in console, which broke when we moved them into devtools.