[EuiComboBox] Clean duplicated values before adding them#8335
Merged
tkajtoch merged 7 commits intoelastic:mainfrom Mar 5, 2025
Merged
[EuiComboBox] Clean duplicated values before adding them#8335tkajtoch merged 7 commits intoelastic:mainfrom
tkajtoch merged 7 commits intoelastic:mainfrom
Conversation
dfvalero
changed the title
tkajtoch
reviewed
Feb 19, 2025
| @@ -0,0 +1,3 @@ | |||
| **Bug fixes** | |||
|
|
|||
| - Fixed `EuiComboBox` by cleaning duplicated values when having a delimiter prop. | |||
Member
There was a problem hiding this comment.
While this certainly could be classified as a bug fix, I think we should mark it as a breaking change. This is something customer applications might've been aware of and use in specific ways
Member
|
We should wait to merge this until after next week's release. Next week's release will already be quite large. |
Contributor
Author
|
Hey @JasonStoltz , sure. Feel free to approve the PR once the release is finished. |
Member
|
FYI I updated the changelog type to |
Contributor
Author
|
Hi @tkajtoch Thanks, no problem! |
Member
|
We'll merge this PR and release the changes in the next hour :) |
|
Preview staging links for this PR:
|
Collaborator
💚 Build Succeeded
History
|
tkajtoch
approved these changes
Mar 5, 2025
Member
tkajtoch
left a comment
tkajtoch
left a comment
There was a problem hiding this comment.
Changes look and work great. Thanks for the contribution!
tkajtoch
added a commit
to elastic/kibana
that referenced
this pull request
Mar 6, 2025
`99.4.0-borealis.0` ⏩ `100.0.0` [Questions? Please see our Kibana upgrade FAQ.](https://github.com/elastic/eui/blob/main/wiki/eui-team-processes/upgrading-kibana.md#faq-for-kibana-teams) --- First of all, 💯 🎉! > [!Warning] > Please note that the [public changelog for EUI v100.0.0](https://github.com/elastic/eui/releases/tag/v100.0.0) is longer than what's included below. > > Kibana has been using Borealis-specific builds of EUI since November last year (suffixed with `-borealis.X`), which were built from a just-merged EUI feature branch. > Since that feature branch just got merged and released with EUI v100.0.0, **the public changelog differs from what Kibana should be concerned about** due to updating from a custom Borealis-enabled version of EUI. > > You can find the list of all (one 👀) changes made between version `99.4.0-borealis.0` and `100.0.0` below. ## [`v100.0.0`](https://github.com/elastic/eui/releases/v100.0.0) **Bug fixes** - Fixed `EuiComboBox` by cleaning duplicated values when having a delimiter prop. ([#8335](elastic/eui#8335)) Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Mar 6, 2025
`99.4.0-borealis.0` ⏩ `100.0.0` [Questions? Please see our Kibana upgrade FAQ.](https://github.com/elastic/eui/blob/main/wiki/eui-team-processes/upgrading-kibana.md#faq-for-kibana-teams) --- First of all, 💯 🎉! > [!Warning] > Please note that the [public changelog for EUI v100.0.0](https://github.com/elastic/eui/releases/tag/v100.0.0) is longer than what's included below. > > Kibana has been using Borealis-specific builds of EUI since November last year (suffixed with `-borealis.X`), which were built from a just-merged EUI feature branch. > Since that feature branch just got merged and released with EUI v100.0.0, **the public changelog differs from what Kibana should be concerned about** due to updating from a custom Borealis-enabled version of EUI. > > You can find the list of all (one 👀) changes made between version `99.4.0-borealis.0` and `100.0.0` below. ## [`v100.0.0`](https://github.com/elastic/eui/releases/v100.0.0) **Bug fixes** - Fixed `EuiComboBox` by cleaning duplicated values when having a delimiter prop. ([elastic#8335](elastic/eui#8335)) Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> (cherry picked from commit 18fa931)
tkajtoch
added a commit
to elastic/kibana
that referenced
this pull request
Mar 7, 2025
# Backport This is a manual backport of #212974 and #213292 --- `99.3.0-classic.0` ⏩ `100.0.0-classic.0` [Questions? Please see our Kibana upgrade FAQ.](https://github.com/elastic/eui/blob/main/wiki/eui-team-processes/upgrading-kibana.md#faq-for-kibana-teams) --- ## [`v100.0.0`](https://github.com/elastic/eui/releases/v100.0.0) **Bug fixes** - Fixed `EuiComboBox` by cleaning duplicated values when having a delimiter prop. ([#8335](elastic/eui#8335)) ## [`v99.4.0`](https://github.com/elastic/eui/releases/v99.4.0) - Minor design updates to `EuiCollapsibleNavBeta` ([#8332](elastic/eui#8332)) - Allow section without a title - Second-level icons should be horizontally aligned with the top-level icon - Turn off text truncation for nav items - Added `quickSelectButtonProps` to `EuiSuperDatePicker` ([#8380](elastic/eui#8380)) **Bug fixes** - Fixed a bug in `EuiHeader` where the navigation of `EuiCollapsibleNavBeta` would render below the `EuiFlyout`'s overlay ([#8325](elastic/eui#8325)) **Accessibility** - Improved the accessibility of `EuiComboBox` by adding `aria-setsize` and `aria-posinset` to ensure correct information is provided for its virtualized listbox ([#8333](elastic/eui#8333)) - Improved the `EuiAccordionTrigger`'s screen reader UX by passed `aria-hidden` to the `EuiAccordionArrow` to avoid duplicated announcements by screen readers. ([#8342](elastic/eui#8342)) --------- Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this pull request
Mar 22, 2025
`99.4.0-borealis.0` ⏩ `100.0.0` [Questions? Please see our Kibana upgrade FAQ.](https://github.com/elastic/eui/blob/main/wiki/eui-team-processes/upgrading-kibana.md#faq-for-kibana-teams) --- First of all, 💯 🎉! > [!Warning] > Please note that the [public changelog for EUI v100.0.0](https://github.com/elastic/eui/releases/tag/v100.0.0) is longer than what's included below. > > Kibana has been using Borealis-specific builds of EUI since November last year (suffixed with `-borealis.X`), which were built from a just-merged EUI feature branch. > Since that feature branch just got merged and released with EUI v100.0.0, **the public changelog differs from what Kibana should be concerned about** due to updating from a custom Borealis-enabled version of EUI. > > You can find the list of all (one 👀) changes made between version `99.4.0-borealis.0` and `100.0.0` below. ## [`v100.0.0`](https://github.com/elastic/eui/releases/v100.0.0) **Bug fixes** - Fixed `EuiComboBox` by cleaning duplicated values when having a delimiter prop. ([elastic#8335](elastic/eui#8335)) Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #8334
This PR updates EuiComboBox by cleaning duplicated values when having a delimiter prop.
QA
Demo
demo.mov
General checklist
Added documentationProps have proper autodocs (using@defaultif default values are missing) and playground togglesChecked Code Sandbox works for any docs examplesIf applicable, added the breaking change issue label (and filled out the breaking change checklist)If applicable, file an issue to update EUI's Figma library with any corresponding UI changes. (This is an internal repo, if you are external to Elastic, ask a maintainer to submit this request)