Skip to content

fix import for ES6 module#8406

Closed
thomasneirynck wants to merge 2 commits intoelastic:masterfrom
thomasneirynck:fix/8378
Closed

fix import for ES6 module#8406
thomasneirynck wants to merge 2 commits intoelastic:masterfrom
thomasneirynck:fix/8378

Conversation

@thomasneirynck
Copy link
Contributor

for #8378

The require() call imports all the exports, not just the default. Since we load input/output dynamically , we can't hoist these to the top either and use import syntax.

Using require on ES6 modules we cannot access the default export directly.
@jbudz
Copy link
Contributor

jbudz commented Sep 21, 2016

related #8342?

@thomasneirynck
Copy link
Contributor Author

@jbudz uh yep, thx, this is the same. I'll close this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments