[EuiCollapsibleNavBeta] Minor design enhancements#8332
Merged
tkajtoch merged 9 commits intoelastic:mainfrom Feb 25, 2025
Merged
[EuiCollapsibleNavBeta] Minor design enhancements#8332tkajtoch merged 9 commits intoelastic:mainfrom
tkajtoch merged 9 commits intoelastic:mainfrom
Conversation
tsullivan
force-pushed
the
sidenav-design-enhancements-i
branch
from
12c62ee to
0b612f8
Compare
tsullivan
force-pushed
the
sidenav-design-enhancements-i
branch
from
e2841a5 to
97a9fae
Compare
tkajtoch
reviewed
Feb 24, 2025
tkajtoch
approved these changes
Feb 25, 2025
Member
tkajtoch
left a comment
tkajtoch
left a comment
There was a problem hiding this comment.
Code changes look great. I tested the visual changes in Storybook and confirmed they render as expected.
I'm going to commit my suggestion about the changelog update and merge this PR.
|
Preview staging links for this PR:
|
Collaborator
💚 Build Succeeded
History
cc @tsullivan |
This was referenced Mar 3, 2025
tkajtoch
added a commit
to elastic/kibana
that referenced
this pull request
Mar 7, 2025
# Backport This is a manual backport of #212974 and #213292 --- `99.3.0-classic.0` ⏩ `100.0.0-classic.0` [Questions? Please see our Kibana upgrade FAQ.](https://github.com/elastic/eui/blob/main/wiki/eui-team-processes/upgrading-kibana.md#faq-for-kibana-teams) --- ## [`v100.0.0`](https://github.com/elastic/eui/releases/v100.0.0) **Bug fixes** - Fixed `EuiComboBox` by cleaning duplicated values when having a delimiter prop. ([#8335](elastic/eui#8335)) ## [`v99.4.0`](https://github.com/elastic/eui/releases/v99.4.0) - Minor design updates to `EuiCollapsibleNavBeta` ([#8332](elastic/eui#8332)) - Allow section without a title - Second-level icons should be horizontally aligned with the top-level icon - Turn off text truncation for nav items - Added `quickSelectButtonProps` to `EuiSuperDatePicker` ([#8380](elastic/eui#8380)) **Bug fixes** - Fixed a bug in `EuiHeader` where the navigation of `EuiCollapsibleNavBeta` would render below the `EuiFlyout`'s overlay ([#8325](elastic/eui#8325)) **Accessibility** - Improved the accessibility of `EuiComboBox` by adding `aria-setsize` and `aria-posinset` to ensure correct information is provided for its virtualized listbox ([#8333](elastic/eui#8333)) - Improved the `EuiAccordionTrigger`'s screen reader UX by passed `aria-hidden` to the `EuiAccordionArrow` to avoid duplicated announcements by screen readers. ([#8342](elastic/eui#8342)) --------- Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Needed for https://github.com/elastic/kibana-team/issues/1439
Screenshots
Before
After
QA
Remove or strikethrough items that do not apply to your PR.
General checklist
@defaultif default values are missing) and playground toggles