Merged
Conversation
tkajtoch
added
v9.1.0
release_note:skip
…er of elements of the correct selector
tkajtoch
force-pushed
the
feat/eui-99.4.0
branch
from
0510077 to
8c6fa4a
Compare
tkajtoch
commented
Mar 3, 2025
| const selector = getByTestId('cloud-defend-selector'); | ||
|
|
||
| // should start as closed. | ||
| // there are two mock selectors, and the last one will auto open |
Member
Author
There was a problem hiding this comment.
This was incorrect. The old length of 2 was not a result of 2 selectors being rendered but each EuiAccordionTrigger rendering two collapse/expand buttons - one button icon for the arrow and one as a wrapper for the buttonContent. This was recently fixed in elastic/eui#8342 by adding aria-hidden to the button icon making it ignored by RTL
kowalczyk-krzysztof
approved these changes
Mar 4, 2025
tkajtoch
added
v9.0.0
backport:prev-minor
and removed
backport:skip
tkajtoch
commented
Mar 4, 2025
| if (!isEuiCollapsibleNavItemProps(props)) { | ||
| throw new Error(`Invalid EuiCollapsibleNavItem props for node ${props.id}`); | ||
| throw new Error( | ||
| `Invalid EuiCollapsibleNavItem props for node ${(props as EuiCollapsibleNavSubItemProps).id}` |
Member
Author
There was a problem hiding this comment.
With the updated types in https://github.com/elastic/eui/pull/8332/files#diff-86282e52a76bc99796d93869317a478caec87064dc42551ac89ca2fc2950a2d5 TS has a hard time getting the right type here resulting in props being of type never after the isEuiCollapsibleNavItemProps check.
We'll be reassessing EUI's more complex types to get rid of this and similar issues.
delanni
approved these changes
Mar 4, 2025
Contributor
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]Page load bundle
History
cc @tkajtoch |
yctercero
approved these changes
Mar 4, 2025
maxcold
approved these changes
Mar 5, 2025
Contributor
|
Starting backport for target branches: 9.0 https://github.com/elastic/kibana/actions/runs/13676764003 |
kfirpeled
approved these changes
Mar 5, 2025
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Mar 5, 2025
(cherry picked from commit 75f9c61)
Contributor
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Mar 5, 2025
# Backport This will backport the following commits from `main` to `9.0`: - [Upgrade EUI to v99.4.0 (#212974)](#212974) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Tomasz Kajtoch","email":"tomasz.kajtoch@elastic.co"},"sourceCommit":{"committedDate":"2025-03-05T13:09:55Z","message":"Upgrade EUI to v99.4.0 (#212974)","sha":"75f9c6113d7815f542f97ad37dcec7ffe6263f23","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:prev-minor","v9.1.0"],"title":"Upgrade EUI to v99.4.0","number":212974,"url":"https://github.com/elastic/kibana/pull/212974","mergeCommit":{"message":"Upgrade EUI to v99.4.0 (#212974)","sha":"75f9c6113d7815f542f97ad37dcec7ffe6263f23"}},"sourceBranch":"main","suggestedTargetBranches":["9.0"],"targetPullRequestStates":[{"branch":"9.0","label":"v9.0.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/212974","number":212974,"mergeCommit":{"message":"Upgrade EUI to v99.4.0 (#212974)","sha":"75f9c6113d7815f542f97ad37dcec7ffe6263f23"}}]}] BACKPORT--> Co-authored-by: Tomasz Kajtoch <tomasz.kajtoch@elastic.co>
tkajtoch
added a commit
that referenced
this pull request
Mar 7, 2025
# Backport This is a manual backport of #212974 and #213292 --- `99.3.0-classic.0` ⏩ `100.0.0-classic.0` [Questions? Please see our Kibana upgrade FAQ.](https://github.com/elastic/eui/blob/main/wiki/eui-team-processes/upgrading-kibana.md#faq-for-kibana-teams) --- ## [`v100.0.0`](https://github.com/elastic/eui/releases/v100.0.0) **Bug fixes** - Fixed `EuiComboBox` by cleaning duplicated values when having a delimiter prop. ([#8335](elastic/eui#8335)) ## [`v99.4.0`](https://github.com/elastic/eui/releases/v99.4.0) - Minor design updates to `EuiCollapsibleNavBeta` ([#8332](elastic/eui#8332)) - Allow section without a title - Second-level icons should be horizontally aligned with the top-level icon - Turn off text truncation for nav items - Added `quickSelectButtonProps` to `EuiSuperDatePicker` ([#8380](elastic/eui#8380)) **Bug fixes** - Fixed a bug in `EuiHeader` where the navigation of `EuiCollapsibleNavBeta` would render below the `EuiFlyout`'s overlay ([#8325](elastic/eui#8325)) **Accessibility** - Improved the accessibility of `EuiComboBox` by adding `aria-setsize` and `aria-posinset` to ensure correct information is provided for its virtualized listbox ([#8333](elastic/eui#8333)) - Improved the `EuiAccordionTrigger`'s screen reader UX by passed `aria-hidden` to the `EuiAccordionArrow` to avoid duplicated announcements by screen readers. ([#8342](elastic/eui#8342)) --------- Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this pull request
Mar 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
99.3.0-borealis.0⏩99.4.0-borealis.0Questions? Please see our Kibana upgrade FAQ.
v99.4.0EuiCollapsibleNavBeta(#8332)quickSelectButtonPropstoEuiSuperDatePicker(#8380)Bug fixes
EuiHeaderwhere the navigation ofEuiCollapsibleNavBetawould render below theEuiFlyout's overlay (#8325)Accessibility
EuiComboBoxby addingaria-setsizeandaria-posinsetto ensure correct information is provided for its virtualized listbox (#8333)EuiAccordionTrigger's screen reader UX by passedaria-hiddento theEuiAccordionArrowto avoid duplicated announcements by screen readers. (#8342)