[backport] PR #8342 to 5.x - [console] Fix settings#8489
Closed
elastic-jasper wants to merge 1 commit into5.xfrom
Closed
[backport] PR #8342 to 5.x - [console] Fix settings#8489elastic-jasper wants to merge 1 commit into5.xfrom
elastic-jasper wants to merge 1 commit into5.xfrom
Conversation
--------- **Commit 1:** [console] fix references to getInput function When splitting the input/output modules into an `initializeInput` and `getInput` pair, it was changed to an esModule. This means that you can no longer require is and execute it's default export directly, as was being done in the console's settings module. * Original sha: 086a40c * Authored by spalger <email@spalger.com> on 2016-09-19T20:18:27Z **Commit 2:** [console] add functional tests to ensure that settings work * Original sha: 752c333 * Authored by spalger <email@spalger.com> on 2016-09-19T20:23:07Z
epixa
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport PR #8342
Commit 1:
[console] fix references to getInput function
When splitting the input/output modules into an
initializeInputandgetInputpair, it was changed to an esModule. This means that you can no longer require is and execute it's default export directly, as was being done in the console's settings module.Commit 2:
[console] add functional tests to ensure that settings work