Closed
Conversation
- Migrate from absolute imports to relative imports. - Reorganize files for clearer hierarchy. - Represent one concern per file. - Aggregate route definitions in one place. - Clarify entry points into code, with clear dependencies.
cjcenizal
commented
Sep 17, 2016
| </div> | ||
| <p class="wizard-type-description">{{type.description}}</p> | ||
| </a> | ||
| <div class="container-fluid vis-wizard"> |
Contributor
Author
There was a problem hiding this comment.
This file remains unchanged, except for the addition of a new root element.
| <saved-object-finder | ||
| title="Saved Searches" | ||
| type="searches" | ||
| <div class="container-fluid vis-wizard"> |
Contributor
Author
There was a problem hiding this comment.
This file remains unchanged, except for the addition of a new root element.
Contributor
Author
|
This is a very low priority, and I don't think I'll have time to get back to this in the foreseeable future. |
tkajtoch
added a commit
that referenced
this pull request
Mar 7, 2025
# Backport This is a manual backport of #212974 and #213292 --- `99.3.0-classic.0` ⏩ `100.0.0-classic.0` [Questions? Please see our Kibana upgrade FAQ.](https://github.com/elastic/eui/blob/main/wiki/eui-team-processes/upgrading-kibana.md#faq-for-kibana-teams) --- ## [`v100.0.0`](https://github.com/elastic/eui/releases/v100.0.0) **Bug fixes** - Fixed `EuiComboBox` by cleaning duplicated values when having a delimiter prop. ([#8335](elastic/eui#8335)) ## [`v99.4.0`](https://github.com/elastic/eui/releases/v99.4.0) - Minor design updates to `EuiCollapsibleNavBeta` ([#8332](elastic/eui#8332)) - Allow section without a title - Second-level icons should be horizontally aligned with the top-level icon - Turn off text truncation for nav items - Added `quickSelectButtonProps` to `EuiSuperDatePicker` ([#8380](elastic/eui#8380)) **Bug fixes** - Fixed a bug in `EuiHeader` where the navigation of `EuiCollapsibleNavBeta` would render below the `EuiFlyout`'s overlay ([#8325](elastic/eui#8325)) **Accessibility** - Improved the accessibility of `EuiComboBox` by adding `aria-setsize` and `aria-posinset` to ensure correct information is provided for its virtualized listbox ([#8333](elastic/eui#8333)) - Improved the `EuiAccordionTrigger`'s screen reader UX by passed `aria-hidden` to the `EuiAccordionArrow` to avoid duplicated announcements by screen readers. ([#8342](elastic/eui#8342)) --------- Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
This experiment implements some proposed "best practices":
I'd like to implement these practices throughout our codebase, to make it easier to migrate to the new Kibana architecture (whatever that ends up being).
These changes should also make code easier to follow and maintain, so please assess this PR from that standpoint.
Next step
For now, my immediate goal is to apply these practices to only the Visualize app, and use it as a test case for migrating an app to various new Kibana architectural prototypes. After this PR is merged, I'll move on to the "saved_visualizations" and "editor" sections of Visualize.
Impact
If we move forward and merge these changes, we'll need to backport them to 5.x and 5.0, to support easy backporting of future bug fixes in this code.