5.X - Backport recent @spalger prs#8504
Merged
spalger merged 5 commits intoelastic:5.xfrom Sep 30, 2016
Merged
Conversation
added 5 commits
September 30, 2016 13:50
[refactor] extract tab styles from navbar to "localTabs" While moving the kbn-dev-tools-app directive to use kbn-top-nav, it became obvious that a change to the tab styles was necessary. Unfortunately they were all tied closely to the navbar-static-top class. Chatted with CJ and he already had a new version of the tabs running in the styleguide, so I just ported them over here and replaced our uses with the new ones. (cherry picked from commit 7a3262f)
[kbnDevToolsApp] allow extending the top nav The kbn-dev-tools-app directive renders a navbar above each devtool, giving it breadcrumbs and links to the other devtools. This collides with the toolbars used in devtools like console and causes two mostly-empty toolbars to be stacked. To fix this, we are merging the navbar from kbn-dev-tools-app and the toolbar provided by the devtools into a single kbn-top-nav toolbar. Console already used the kbn-top-nav directive for it's navbar, so kbn-dev-tools-app just needed to be extended to consume and render the kbn-top-nav configuration (a controller in this instance). (cherry picked from commit 5bff9da)
[console] fix references to getInput function When splitting the input/output modules into an `initializeInput` and `getInput` pair, it was changed to an esModule. This means that you can no longer require is and execute it's default export directly, as was being done in the console's settings module. (cherry picked from commit 086a40c)
[vislib/tilemap] ensure listeners are cleaned up With the new "rendered" event, the listener added in the handler was not being cleaned up. This changes it to use the handler's `binder`, which will cleanup the listener when `handler.destroy()` is called.
[functionalTests/console] fix test subject selector by focusing on help-specific button
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport #8350
Backport #8342
Backport #8355
Backport #8439
Backport #8420