Upgrade EUI to v20.0.2 by chandlerprall · Pull Request #59199 · elastic/kibana

chandlerprall · 2020-03-03T18:44:57Z

Summary

Contains the usual jest snapshot test updates, as well as some TypeScript updates as EuiCodeEditor and EuiComboBox were converted. Most TypeScript changes are to types and not runtime code, apart from a couple null checks.

`20.0.2`

Bug fixes

Fixed type definitions for EuiComboBox (#2971)

`20.0.1`

Bug fixes

Added TypeScript definition for EuiCodeEditor's accepting react-ace props (#2926)
Added @types/react-input-autosize to project's dependencies (#2930)

`20.0.0`

Converted EuiComboBox, EuiComboBoxInput, EuiComboBoxPill, EuiComboBoxOptionsList, EuiComboBoxOption, and EuiComboBoxTitle to TypeScript (#2838)
Converted EuiCodeEditor to TypeScript (#2836)
Converted EuiCode and EuiCodeBlock and to TypeScript (#2835)
Converted EuiFilePicker to TypeScript (#2832)
Exported EuiSelectOptionProps type (#2830)
Added paperClip glyph to EuiIcon (#2845)
Added banner prop to EuiFlyoutBody and updated euiOverflowShadow mixin (#2837)
Updated editorLink icon (#2866)
Added control columns to EuiDataGrid to support non-data columns like row selection and actions (#2846)
Added image glyph to EuiIcon (#2870)
Exported TS props from top level EuiListGroupProps, EuiListGroupItemProps, EuiSelectableProps, EuiSelectableOption, EuiSelectableOptionsListProps (#2869)
Extending EuiSelectable[options] type with correct HTML element (#2869)
Added check mark to single selection EuiComboBox (#2890)
Added logoGoogleG third-party logo to EuiIcon (#2853)
Added Jest modulesNameMapper alias for EuiIcon using test environment mock (#2878)
Removed sinon and @types/sinon as dependencies, and converted usages to jest.fn (#2885)

Bug fixes

Fixed building dev & docs on Windows (#2847)
Fixed screen reader discovery issues with EuiBottomBar and EuiControlBar (#2861)
Fixed a bug in EuiDataGrid causing the first cell to autofocus if interactive (#2872)

Breaking changes

Removed visControls and visHeatmap duplicate icons from docs (#2908)

Checklist

Delete any items that are not applicable to this PR.

Unit or functional tests were updated or added to match the most common scenarios

For maintainers

This was checked for breaking API changes and was labeled appropriately

src/plugins/advanced_settings/public/management_app/components/field/field.tsx

...ion/data_frame_analytics/pages/analytics_management/hooks/use_create_analytics_form/state.ts

legrego

Security/Spaces changes LGTM - tested locally.

spalger

@kbn/ui-shared-deps update LGTM

...k/plugins/triggers_actions_ui/public/application/components/builtin_action_types/webhook.tsx

lizozom

App Arch changes LGTM

walterra

ML & transform changes LGTM

weltenwort

👀 Reviewing on behalf of @elastic/logs-metrics-ui...

YulNaumenko

LGTM, I've posted a question about removing isInvalid for EuiCodeEditor.

weltenwort

infra changes LGTM

igoristic

Looks good with Stack Monitoring, and all tests seem to be passing 👍

poffdeluxe

canvas changes seem to work just fine 👍

thompsongl

TS and snapshot changes LGTM; spot-checked locally

kibanamachine · 2020-03-05T19:01:15Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: 153073e

History

💚 Build #30998 succeeded 0a1c55f18ea352cabf321e7a0c78c7bc4ab37d33
💔 Build #30808 failed 9ca47af837032b510330e9c7e5dc52ef63f0202b
💔 Build #30474 failed dca18ad528f1ff4859ae5c2a704f7b82c802250e

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

* Updated EUI to 20.0.1; updated typescript usage * snapshots * Upgrade to eui 20.0.2, fix one more type * PR feedback * Update EUI icon usage to the correct types * Updated with master

kibanamachine · 2020-03-06T19:28:45Z

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

* Upgrade EUI to v20.0.2 (#59199) * Updated EUI to 20.0.1; updated typescript usage * snapshots * Upgrade to eui 20.0.2, fix one more type * PR feedback * Update EUI icon usage to the correct types * Updated with master * Fixed a missing import

chandlerprall added v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.7.0 labels Mar 3, 2020

chandlerprall requested a review from thompsongl March 3, 2020 18:44

chandlerprall requested a review from a team as a code owner March 3, 2020 18:44

chandlerprall requested a review from a team March 3, 2020 18:44

chandlerprall requested review from a team as code owners March 3, 2020 18:44

myasonik approved these changes Mar 3, 2020

View reviewed changes

legrego requested review from a team and legrego and removed request for a team March 3, 2020 19:04

legrego approved these changes Mar 3, 2020

View reviewed changes

spalger approved these changes Mar 3, 2020

View reviewed changes

YulNaumenko reviewed Mar 3, 2020

View reviewed changes

...k/plugins/triggers_actions_ui/public/application/components/builtin_action_types/webhook.tsx Outdated Show resolved Hide resolved

YulNaumenko requested review from a team and YulNaumenko March 3, 2020 22:11

lizozom approved these changes Mar 4, 2020

View reviewed changes

walterra approved these changes Mar 4, 2020

View reviewed changes

Dosant mentioned this pull request Mar 4, 2020

[wip][Drilldowns] Drilldown Wizard Components #59139

Closed

7 tasks

weltenwort reviewed Mar 4, 2020

View reviewed changes

YulNaumenko approved these changes Mar 4, 2020

View reviewed changes

weltenwort approved these changes Mar 4, 2020

View reviewed changes

igoristic approved these changes Mar 4, 2020

View reviewed changes

poffdeluxe approved these changes Mar 5, 2020

View reviewed changes

Updated EUI to 20.0.1; updated typescript usage

273f7fb

chandlerprall added 5 commits March 5, 2020 09:31

snapshots

42bb739

Upgrade to eui 20.0.2, fix one more type

410362a

PR feedback

872a7b5

Update EUI icon usage to the correct types

3ee1f0a

Updated with master

153073e

chandlerprall force-pushed the eui-20-0-2 branch from 0a1c55f to 153073e Compare March 5, 2020 17:05

thompsongl approved these changes Mar 5, 2020

View reviewed changes

chandlerprall merged commit 096dda6 into elastic:master Mar 5, 2020

chandlerprall mentioned this pull request Mar 5, 2020

[7.x] Upgrade EUI to v20.0.2 (#59199) #59477

Merged

kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Mar 6, 2020

chandlerprall deleted the eui-20-0-2 branch March 6, 2020 19:46

kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Mar 6, 2020

Comments

Conversation

chandlerprall commented Mar 3, 2020

Summary

20.0.2

20.0.1

20.0.0

Checklist

For maintainers

Uh oh!

Uh oh!

Uh oh!

Uh oh!

legrego left a comment

Choose a reason for hiding this comment

Uh oh!

spalger left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

lizozom left a comment

Choose a reason for hiding this comment

Uh oh!

walterra left a comment

Choose a reason for hiding this comment

Uh oh!

weltenwort left a comment

Choose a reason for hiding this comment

Uh oh!

YulNaumenko left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

weltenwort left a comment

Choose a reason for hiding this comment

Uh oh!

igoristic left a comment

Choose a reason for hiding this comment

Uh oh!

poffdeluxe left a comment

Choose a reason for hiding this comment

Uh oh!

thompsongl left a comment

Choose a reason for hiding this comment

Uh oh!

kibanamachine commented Mar 5, 2020

💚 Build Succeeded

History

Uh oh!

kibanamachine commented Mar 6, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

12 participants

`20.0.2`

`20.0.1`

`20.0.0`

YulNaumenko left a comment •

edited

Loading