converts EuiCode and EuiCodeBlock to TypeScript#2835
converts EuiCode and EuiCodeBlock to TypeScript#2835chandlerprall merged 11 commits intoelastic:masterfrom
Conversation
|
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
dimitropoulos
force-pushed
the
code-block-ts
branch
from
8685c73 to
2310a4f
Compare
| function MutationNotifier() { | ||
| var _this = _super.call(this) || this; | ||
| _this.setMaxListeners(150); // bump this as needed - some tests do not perform the unmounting lifecycle | ||
| _this.setMaxListeners(294); // bump this as needed - some tests do not perform the unmounting lifecycle |
There was a problem hiding this comment.
This is suspicious to me, but it's all that worked to get past the pre-commit hook. Any deeper insight is appreciated.
There was a problem hiding this comment.
Definitely agree, I'll take a deeper look at this.
There was a problem hiding this comment.
note: at the time I made this PR this change was necessary on master as well
There was a problem hiding this comment.
Very interesting; can you provide some details on your setup:
- operating system & version
- yarn version (and confirm you used
yarnto install EUI's dependencies, notnpm) - confirm the
jestpackage used comes fromeui/node_modules/jestand not a global install
There was a problem hiding this comment.
λ $ uname -a
Linux dimitri 5.3.0-26-generic #28-Ubuntu SMP Wed Dec 18 05:37:46 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
λ $ lsb_release -a
No LSB modules are available.
Distributor ID: Ubuntu
Description: Ubuntu 19.10
Release: 19.10
Codename: eoan
λ $ yarn --version
1.21.1
λ $ jest
Command 'jest' not found, did you mean:
command 'test' from deb coreutils (8.30-3ubuntu2)
Try: sudo apt install <deb name>
There was a problem hiding this comment.
would you like me to remove the commit where I upped the count or shall we just leave it in?
chandlerprall
left a comment
chandlerprall
left a comment
There was a problem hiding this comment.
Thanks for putting this together, @dimitropoulos!
Left a couple comments - (almost?) everything is small to align better with our patterns (which, as you observed, aren't always well followed to begin with and aren't documented [which is coming...])
After these, I'll take a second pass on some of those shared prop definitions along with verifying backwards compatibility.
dimitropoulos
force-pushed
the
code-block-ts
branch
from
04fceba to
136cc4a
Compare
chandlerprall
left a comment
chandlerprall
left a comment
There was a problem hiding this comment.
Two additional things on the exported types, otherwise this looks great
dimitropoulos
force-pushed
the
code-block-ts
branch
from
23bcef8 to
3c0a28f
Compare
chandlerprall
left a comment
chandlerprall
left a comment
There was a problem hiding this comment.
One final change requested; everything else looks good, pulled & tested locally, built eui.d.ts and confirmed the expected values are available from the @elastic/eui package space
dimitropoulos
force-pushed
the
code-block-ts
branch
from
636be6d to
15cbc88
Compare
chandlerprall
left a comment
chandlerprall
left a comment
There was a problem hiding this comment.
Changes LGTM! Thank you very much for investing the time and effort on this @dimitropoulos , we really appreciate it!
|
jenkins test this will merge on green ci |
|
My pleasure! |
|
hey and by the way @chandlerprall (or anyone else) if anything comes up regarding improvements or bugs for this in the future feel free to ping me - I can't promise I will have time to help but I can promise I'll try! :) |
5 participants
Summary
closes #2665
Checklist