Add Google G logo to third party logos#2853
Merged
andreadelrio merged 7 commits intoelastic:masterfrom Feb 24, 2020
Merged
Conversation
elizabetdev
suggested changes
Feb 17, 2020
Contributor
elizabetdev
left a comment
elizabetdev
left a comment
There was a problem hiding this comment.
LGTM! 🎉
I just suggest optimizing the SVG a little bit more.
snide
reviewed
Feb 21, 2020
Contributor
snide
left a comment
snide
left a comment
There was a problem hiding this comment.
This looks good to go after an upstream merge. Probably want to double check your changelog is still against master.
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_2853/ |
elizabetdev
approved these changes
Feb 24, 2020
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_2853/ |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #2811
Note: Some files I didn't directly edit have been updated. I'm guessing this is a result of running
yarn compile-iconsChecklist
- [] Check against all themes for compatibility in both light and dark modes- [ ] Checked in mobile- [ ] Checked in IE11 and Firefox- [ ] Props have proper autodocs- [ ] Checked for breaking changes and labeled appropriately- [ ] Checked for accessibility including keyboard-only and screenreader modes