Export select option type#2830
Merged
chandlerprall merged 9 commits intoelastic:masterfrom Feb 10, 2020
Merged
Conversation
chandlerprall
suggested changes
Feb 6, 2020
chandlerprall
suggested changes
Feb 7, 2020
Contributor
|
Also needs a CHANGELOG.md entry, like Line 9 in c2eb8d9 |
Contributor
|
jenkins test this |
update changelog
changelog entry style
chandlerprall
approved these changes
Feb 10, 2020
Contributor
chandlerprall
left a comment
chandlerprall
left a comment
There was a problem hiding this comment.
LGTM; pulled & tested locally, including eui.d.ts build to confirm the type is exported.
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
It would be helpful to be able to import the Option type into my kibana code. This is partial work as I'm not sure how what I'm attempting here works with the typedef files. A small nudge should help it across the line.
Checklist