Fixes #2217 : removed duplicate icons

[anishagg17]

Summary

Fixes #2217 : removed duplicate icons.
Kept generic icons and Removed app specific versions

Breaking changes & Suggested upgrade

• Swap instances of visControls icon with controlsHorizontal
• Swap instances of visHeatmap icon with heatmap

Checklist

• Check against all themes for compatibility in both light and dark modes
• Checked in mobile
• Checked in IE11 and Firefox
• [ ] Props have proper autodocs
• Added documentation examples
• Added or updated jest tests
• Checked for breaking changes and labeled appropriately
• [ ] Checked for accessibility including keyboard-only and screenreader modes
• A changelog entry exists and is marked appropriately

[kibanamachine]

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

[cchaos]

This PR currently only removes this icon from the list in the docs, but does not remove it as an icon type. You will need to go into src/components/icon/... and remove all references to these icons including their .js and .svg files.

[anishagg17]

@cchaos desired changes have been done

[cchaos]

Thanks @anishagg17, I've sent you a PR anishagg17#1 to help this one get over the line. There was just some confusion over the location of the changelog entry and we have a script we need to run in order to update the tests.

[cchaos]

Jenkins, test this

[anishagg17]

Thanks @cchaos for helping me out with this

[kibanamachine]

Preview documentation changes for this PR: https://eui.elastic.co/pr_2908/

[cchaos]

Changes, LGTM. We'll need to make a not to swap these icons in Kibana.

[cchaos]

Nice one @anishagg17 , thank you!