converts EuiCodeEditor to TypeScript#2836
Conversation
|
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
| function MutationNotifier() { | ||
| var _this = _super.call(this) || this; | ||
| _this.setMaxListeners(150); // bump this as needed - some tests do not perform the unmounting lifecycle | ||
| _this.setMaxListeners(294); // bump this as needed - some tests do not perform the unmounting lifecycle |
There was a problem hiding this comment.
This is suspicious to me, but it's all that worked to get past the pre-commit hook. Any deeper insight is appreciated.
dimitropoulos
force-pushed
the
code-editor-ts
branch
from
cc9d91e to
45fe69e
Compare
chandlerprall
left a comment
chandlerprall
left a comment
There was a problem hiding this comment.
Couple small pattern things, but also:
src/components/code_editor/index.ts should also export EuiCodeEditorProps
|
@dimitropoulos just checking in to see if you are still interested in this & the other TypeScript conversions. In addition to reviewing, we are happy to contribute code/changes directly against your PRs, just let us know what works best for you! |
|
definitely! I have a few more things to push, I'll make sure to push them today! Perhaps we can get these merged sooner than later if so? |
dimitropoulos
force-pushed
the
code-editor-ts
branch
from
45fe69e to
45a023d
Compare
|
Thanks! I won't have a chance to review today, but will check out these new changes first thing tomorrow. |
|
thanks! no rush, was just curious. I was away on a business trip the last week or so, hence the silence - so I was excited to get back to these :) |
dimitropoulos
force-pushed
the
code-editor-ts
branch
2 times, most recently
from
a928368 to
ab06cd0
Compare
chandlerprall
left a comment
chandlerprall
left a comment
There was a problem hiding this comment.
One revert (sorry, again!), plus a final ask and this should be good to go.
chandlerprall
left a comment
chandlerprall
left a comment
There was a problem hiding this comment.
Changes LGTM; pulled & tested locally, including eui.d.ts. Will merge on green ci
|
jenkins test this |
|
hey and by the way @chandlerprall (or anyone else) if anything comes up regarding improvements or bugs for this in the future feel free to ping me - I can't promise I will have time to help but I can promise I'll try! :) |
4 participants
Summary
closes: #2663
Checklist