Skip to content

Comments

Fixes : #2925 Now euiTitle renders classes of children too#2926

Merged
thompsongl merged 5 commits intoelastic:masterfrom
anishagg17:euiTitle
Feb 26, 2020
Merged

Fixes : #2925 Now euiTitle renders classes of children too#2926
thompsongl merged 5 commits intoelastic:masterfrom
anishagg17:euiTitle

Conversation

@anishagg17
Copy link
Contributor

@anishagg17 anishagg17 commented Feb 25, 2020 •
edited
Loading

Summary

Fixes : #2925
Now euiTitle renders classNames of children too

Checklist

  • Check against all themes for compatibility in both light and dark modes
  • Checked in mobile
  • Checked in IE11 and Firefox
  • Props have proper autodocs
  • Added documentation examples
  • Added or updated jest tests
  • Checked for breaking changes and labeled appropriately
  • Checked for accessibility including keyboard-only and screenreader modes
  • A changelog entry exists and is marked appropriately

@kibanamachine
Copy link

kibanamachine commented Feb 25, 2020

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@anishagg17 anishagg17 changed the title Fixes : #2925 euiTitle Fixes : #2925 Now euiTitle renders classes of children too Feb 25, 2020
thompsongl
thompsongl suggested changes Feb 26, 2020
View reviewed changes
Copy link
Contributor

@thompsongl thompsongl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Let's also add a new snapshot test showing this use case.

@anishagg17
Copy link
Contributor Author

anishagg17 commented Feb 26, 2020

@thompsongl changes have been made

thompsongl
thompsongl suggested changes Feb 26, 2020
View reviewed changes
Copy link
Contributor

@thompsongl thompsongl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my other comment also:

Let's also add a new snapshot test showing this use case.

@anishagg17
Copy link
Contributor Author

anishagg17 commented Feb 26, 2020

okay

@anishagg17
Copy link
Contributor Author

anishagg17 commented Feb 26, 2020

@thompsongl Test has been added

thompsongl
thompsongl suggested changes Feb 26, 2020
View reviewed changes
@anishagg17 @thompsongl
Update src/components/title/title.test.tsx
153b688 
Co-Authored-By: Greg Thompson <thompsongl@users.noreply.github.com>
@thompsongl
Copy link
Contributor

thompsongl commented Feb 26, 2020

jenkins test this

cchaos
cchaos reviewed Feb 26, 2020
View reviewed changes
@anishagg17 @cchaos
Update CHANGELOG.md
567df6a 
Co-Authored-By: Caroline Horn <549577+cchaos@users.noreply.github.com>
cchaos
cchaos approved these changes Feb 26, 2020
View reviewed changes
Copy link
Contributor

@cchaos cchaos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks 🎉

@kibanamachine
Copy link

kibanamachine commented Feb 26, 2020

Preview documentation changes for this PR: https://eui.elastic.co/pr_2926/

@thompsongl
Copy link
Contributor

thompsongl commented Feb 26, 2020

jenkins test this

@kibanamachine
Copy link

kibanamachine commented Feb 26, 2020

Preview documentation changes for this PR: https://eui.elastic.co/pr_2926/

thompsongl
thompsongl suggested changes Feb 26, 2020
View reviewed changes
Copy link
Contributor

@thompsongl thompsongl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Snaphots are outdated (from the name change). Need to update them locally

@anishagg17
Copy link
Contributor Author

anishagg17 commented Feb 26, 2020

@thompsongl I have updated SnapShots

@thompsongl
Copy link
Contributor

thompsongl commented Feb 26, 2020

jenkins test this

@kibanamachine
Copy link

kibanamachine commented Feb 26, 2020

Preview documentation changes for this PR: https://eui.elastic.co/pr_2926/

@thompsongl thompsongl merged commit dc199cf into elastic:master Feb 26, 2020
thompsongl added a commit that referenced this pull request Feb 26, 2020
@thompsongl
Move #2926 entry
1e14f51
@anishagg17 anishagg17 deleted the euiTitle branch February 26, 2020 19:38
@chandlerprall chandlerprall mentioned this pull request Mar 3, 2020
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@cchaos cchaos cchaos approved these changes

@thompsongl thompsongl thompsongl approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

EuiTitle wipes out className of cloned child

4 participants

@anishagg17 @kibanamachine @thompsongl @cchaos