Conversation
|
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
1 similar comment
|
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
|
@dimitropoulos I merged #2838 earlier today, so this branch can be rebased. Relevant changes are already looking good, so this PR will be quick. |
dimitropoulos
force-pushed
the
removes-sinon
branch
from
b6c4095 to
1fc80d7
Compare
|
@thompsongl all set and ready to go! |
|
jenkins test this |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_2885/ |
thompsongl
left a comment
thompsongl
left a comment
There was a problem hiding this comment.
Thanks, @dimitropoulos
Even though this is a follow-up PR, let's add a changelog entry. It's worth noting that sinon has been removed entirely.
Ready to merge after the addition
thompsongl
left a comment
thompsongl
left a comment
There was a problem hiding this comment.
Decided to jump in and mark the changelog for you. We want to get this work in the next release, which we're hoping to make today.
Thanks, again, @dimitropoulos
|
jenkins test this |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_2885/ |
|
good stuff - thanks @thompsongl! Yeah, unfortunately I can't really touch this project in any way during work hours (just nights and weekends), so sorry for the delay. |
|
No problem at all! We can jump in if needed, but avoid it when possible. We're just glad you're willing to help when you can! |
|
Good to know: I have a very low ego in these matters (and very little to prove) so please feel free to do anything like in this PR in the future, haha - especially during the workday. I'm cool as a cucumber - just happy to contribute. |
3 participants
🎉
This is a followup from https://github.com/elastic/eui/pull/2838/files#r382108261 and ab06cd0.
(note that there is really only one commit in this PR, but that it's stacked off of https://github.com/elastic/eui/pull/2838/files. once https://github.com/elastic/eui/pull/2838/files merges, I will rebase this and we'll be ready to go with it).