Upgrade EUI to v19.0.0 by thompsongl · Pull Request #57284 · elastic/kibana

thompsongl · 2020-02-10T23:43:28Z

Summary

eui@18.3.0 ⏩ eui@19.0.0

The idAria prop is not longer part of the EuiDescribedFormGroup API. A11y is now handled internally, so all instances have been removed.
EuiCode & EuiCodeBlock now use a React portal in some cases to render complex content. Jest tests for several components need a mocked version until EUI's more robust test environment solution is available (🔜)
The EuiToken change is marked as "breaking", but no instances were yet in use in Kibana

`19.0.0`

Added cheer glyph to EuiIcon (#2814)
Added tableCaption prop to EuiBasicTable and improved the default one (#2782)
Converted EuiDescribedFormGroup to TypeScript (#2810)
Changed SASS comments to non-compiled comments in invisibles files (#2807)
Optimized the third party logos Ceph, DropWizard, Golang, and Haproxy (#2812)
Added rowHeader prop to EuiBasicTable to allow consumers to set the identifying cell in a row (#2802)
Added prepend and append to EuiColorPicker (#2819)
Improved EuiDescribedFormGroup accessibility by avoiding duplicated output in screen readers (#2783)
Added optional key attribute to EuiContextMenu items and relaxed name attribute to allow any React node (#2817)
Converted EuiColorPicker color conversion functions to chroma-js methods (#2805)
Added direction parameter to euiPaletteColorBlind() for specifiying lighter or darker (or both) alternates (#2822)
Converted EuiSideNav to TypeScript (#2818)
Added babel-transformed and partially mocked commonjs build (test-env/) to target Kibana's Jest environment (#2698)
Altered styles of EuiToken and add added more token types to match ES field types of tokenAlias, tokenDate, tokenGeo, tokenIP, tokenNested, tokenRange, tokenShape (#2758)

Bug fixes

Exported missing EuiSelectProps type (#2815)
Fixed EuiCode's & EuiCodeBlock's ability to accept non-string children (#2792) (#2820)
Fixed EuiSearchBar, Query, and AST's ability to accept literal parenthesis characters (#2791)
Fixed coloring of input fields when autofill is on in Chrome (#2798)
Moved @types/enzyme and @types/react-virtualized to dependencies status (#2828)
Removed @elastic/charts from inclusion in eui.d.ts output (#2828)

Breaking changes

Removed idAria prop from EuiDescribedFormGroup (#2783)
Removed EuiToken's hideBorder and displayOptions prop for applying color, shape, and fill props directly. Changed fill prop type from boolean to light | dark | none. (#2758)

chandlerprall

package.json, snaps, and code changes LGTM, but ideally the @types/enzyme installs can be unified.

yarn.lock

cchaos

Yeah nothing for EuiTokens as expected. Looks like most of the changes are for the idAria removal and code block portal stuffs. 👍

cchaos · 2020-02-11T21:22:25Z

src/legacy/server/sass/build.test.js

-     *  - EuiPageContent
-    */
-    foo bar {
+    "foo bar {


myasonik

Looks right to me!

tylersmalley · 2020-02-12T00:33:45Z

I am not sure what we can do about it now - but it's worth keeping an eye on master after merging. What has happened in the past is there are green PR's which have invalid snapshots that ultimately fail when merged into master following an EUI bump.

legrego

Security/Spaces LGTM - tested locally

peteharverson

Tested ML locally and LGTM.

myasonik

One more time for Kibana App 👍

tylersmalley

Looks good for operations 👍

thompsongl · 2020-02-12T16:09:04Z

Pinging @elastic/es-ui to look at the idAria changes

cqliu1

Canvas changes LGTM 👍

afgomez

Infra changes LGTM

alisonelizabeth

es-ui changes LGTM.

thompsongl · 2020-02-14T16:25:42Z

Remaining code owner ping is for a single snapshot update. Will merge when green.

kibanamachine · 2020-02-14T19:01:33Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: 241e841

History

💛 Build #26549 was flaky 6f0a926
💛 Build #26194 was flaky 91749f3
💛 Build #26056 was flaky ffd1e25
💔 Build #26038 failed a7971a9
💚 Build #25929 succeeded ee54d9d

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

* eui to v19.0.0 * typescript updates; idAria removal * src snapshot updates * mock euicode and euicodeblock for jest * x-pack snapshot updates * mock euicode for jest * more euicode snapshots * mock euicode in storyshots * types/enzyme yarn.lock * sidenav type update

thompsongl added 8 commits February 10, 2020 12:17

eui to v19.0.0

8e97838

typescript updates; idAria removal

663deb3

src snapshot updates

f255105

Merge branch 'master' into eui/19.0.0

20b7197

mock euicode and euicodeblock for jest

2c86e95

x-pack snapshot updates

c3d18b7

Merge branch 'master' into eui/19.0.0

9c9721f

mock euicode for jest

e33a184

thompsongl added v8.0.0 release_note:skip Skip the PR/issue when compiling release notes EUI v7.7.0 labels Feb 10, 2020

thompsongl mentioned this pull request Feb 10, 2020

EuiCode & EuiCodeBlock Jest compatibility elastic/eui#2842

Closed

thompsongl added 3 commits February 11, 2020 09:24

Merge branch 'master' into eui/19.0.0

833ca70

more euicode snapshots

4b31e80

mock euicode in storyshots

ee54d9d

thompsongl requested review from aag6z, cchaos, chandlerprall and myasonik and removed request for aag6z February 11, 2020 19:39

chandlerprall approved these changes Feb 11, 2020

View reviewed changes

yarn.lock Outdated Show resolved Hide resolved

cchaos approved these changes Feb 11, 2020

View reviewed changes

src/legacy/server/sass/build.test.js

* - EuiPageContent

*/

foo bar {

"foo bar {

Copy link

Contributor

cchaos Feb 11, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

thompsongl added 2 commits February 11, 2020 15:50

types/enzyme yarn.lock

7555f5f

Merge branch 'master' into eui/19.0.0

a7971a9

myasonik approved these changes Feb 11, 2020

View reviewed changes

sidenav type update

ffd1e25

thompsongl marked this pull request as ready for review February 12, 2020 00:21

thompsongl requested review from a team February 12, 2020 00:21

thompsongl requested review from a team as code owners February 12, 2020 00:21

legrego self-requested a review February 12, 2020 12:32

legrego approved these changes Feb 12, 2020

View reviewed changes

peteharverson approved these changes Feb 12, 2020

View reviewed changes

Merge branch 'master' into eui/19.0.0

91749f3

myasonik approved these changes Feb 12, 2020

View reviewed changes

tylersmalley approved these changes Feb 12, 2020

View reviewed changes

thompsongl added 2 commits February 13, 2020 09:52

Merge branch 'master' into eui/19.0.0

6f0a926

Merge branch 'master' into eui/19.0.0

8b06788

cqliu1 reviewed Feb 14, 2020

View reviewed changes

afgomez approved these changes Feb 14, 2020

View reviewed changes

alisonelizabeth approved these changes Feb 14, 2020

View reviewed changes

Merge branch 'master' into eui/19.0.0

241e841

thompsongl merged commit 0abfd3c into elastic:master Feb 14, 2020

thompsongl mentioned this pull request Feb 14, 2020

[7.x] Upgrade EUI to v19.0.0 (#57284) #57718

Merged

Comments

Conversation

thompsongl commented Feb 10, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

19.0.0

Uh oh!

chandlerprall left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

cchaos left a comment

Choose a reason for hiding this comment

Uh oh!

cchaos Feb 11, 2020

Choose a reason for hiding this comment

Uh oh!

myasonik left a comment

Choose a reason for hiding this comment

Uh oh!

tylersmalley commented Feb 12, 2020

Uh oh!

legrego left a comment

Choose a reason for hiding this comment

Uh oh!

peteharverson left a comment

Choose a reason for hiding this comment

Uh oh!

myasonik left a comment

Choose a reason for hiding this comment

Uh oh!

tylersmalley left a comment

Choose a reason for hiding this comment

Uh oh!

thompsongl commented Feb 12, 2020

Uh oh!

cqliu1 left a comment

Choose a reason for hiding this comment

Uh oh!

afgomez left a comment

Choose a reason for hiding this comment

Uh oh!

alisonelizabeth left a comment

Choose a reason for hiding this comment

Uh oh!

thompsongl commented Feb 14, 2020

Uh oh!

kibanamachine commented Feb 14, 2020

💚 Build Succeeded

History

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

11 participants

thompsongl commented Feb 10, 2020 •

edited

Loading

`19.0.0`