Allowing euiPaletteColorBlind() function to have both light AND dark alternates#2822
Merged
cchaos merged 4 commits intoelastic:masterfrom Feb 4, 2020
Merged
Conversation
added 2 commits
February 3, 2020 17:38
elizabetdev
approved these changes
Feb 4, 2020
Contributor
elizabetdev
left a comment
There was a problem hiding this comment.
Tested locally and checked the code and LGTM! 🎉
Just a suggestion, maybe you could somewhere in the text specify what are the arguments that we can pass to the function.
Contributor
Author
|
@miukimiu I did manually add the function and it's props(parameters) to the Props tab of the sections. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While trying to update the Visualizations in Kibana to use the new palette service. I realized that the alternates provided by
euiPaletteColorBlind()only went one direction (lighter). We should also provide a way to make darker variations so that we can swap this legend color picker with our color palette.So now,
euiPaletteColorBlind()' s third parameterdirectionaccepts'lighter' | 'darker' | 'both'. The docs example has been updated to:And I've added some props documentation for the function.
Checklist
[ ] Checked in mobile[ ] Added or updated jest tests[ ] Checked for breaking changes and labeled appropriately[ ] Checked for accessibility including keyboard-only and screenreader modes