Fix EuiCode / EuiCodeBlock's support for non-string values#2792
Merged
chandlerprall merged 5 commits intoelastic:masterfrom Feb 3, 2020
Merged
Conversation
bevacqua
approved these changes
Jan 27, 2020
thompsongl
approved these changes
Feb 3, 2020
Contributor
thompsongl
left a comment
thompsongl
left a comment
There was a problem hiding this comment.
LGTM. Fixes the prop warnings in the docs, also.
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #2437
When formatting text in an element,
highlight.jsmodifies the DOM which makes React lose references between its Virtual DOM and the browser DOM. I've updatedEuiCodeBlockImplto render its children into a portal and then copy that portal's contents into another element forhighlight.jsto process.Checklist
- [ ] Check against all themes for compatibility in both light and dark modes- [ ] Checked in mobile- [ ] Checked in IE11 and Firefox- [ ] Props have proper autodocs- [ ] Added documentation examples- [ ] Checked for accessibility including keyboard-only and screenreader modes