Merged
Conversation
chandlerprall
suggested changes
Feb 3, 2020
Contributor
chandlerprall
left a comment
chandlerprall
left a comment
There was a problem hiding this comment.
Changes LGTM; pulled & tested locally.
Please add an entry to CHANGELOG.md for this, should be in the master section at the top, under the first group representing feature additions
Contributor
Author
|
@chandlerprall Done. |
chandlerprall
approved these changes
Feb 3, 2020
Contributor
|
Will merge after CI passes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This change will allow us to render more complex context menu items on Dashboard in Kibana, like
Editlink below:Checklist
Check against all themes for compatibility in both light and dark modesChecked in mobileChecked in IE11 and FirefoxProps have proper autodocsAdded documentation examplesChecked for accessibility including keyboard-only and screenreader modesA changelog entry exists and is marked appropriately