Remove extra div wrapping around EuiCode contents#2820
Merged
chandlerprall merged 4 commits intoelastic:masterfrom Feb 3, 2020
Merged
Remove extra div wrapping around EuiCode contents#2820chandlerprall merged 4 commits intoelastic:masterfrom
chandlerprall merged 4 commits intoelastic:masterfrom
Conversation
cchaos
approved these changes
Feb 3, 2020
Contributor
cchaos
left a comment
cchaos
left a comment
There was a problem hiding this comment.
👍 Fixed the problem. Just had a question about the CL
This was referenced Feb 10, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a bug introduced by #2792 which screws up the contents' vertical alignment in at least Firefox. PR removes a wrapping
divfrom the rendering output. Tested changes in Chrome, FF, Safari, Edge, IE11, and Chrome for AndroidChecklist
- [ ] Check against all themes for compatibility in both light and dark modes- [ ] Props have proper autodocs- [ ] Added documentation examples- [ ] Checked for accessibility including keyboard-only and screenreader modes- [ ] A changelog entry exists and is marked appropriately