Convert EuiDescribedFormGroup to typeScript#2810
Merged
elizabetdev merged 7 commits intoelastic:masterfrom Feb 3, 2020
Merged
Conversation
elizabetdev
changed the title
cchaos
suggested changes
Jan 31, 2020
src/components/form/described_form_group/described_form_group.tsx
Outdated
Show resolved
Hide resolved
src/components/form/described_form_group/described_form_group.tsx
Outdated
Show resolved
Hide resolved
src/components/form/described_form_group/described_form_group.tsx
Outdated
Show resolved
Hide resolved
thompsongl
suggested changes
Jan 31, 2020
Contributor
thompsongl
left a comment
thompsongl
left a comment
There was a problem hiding this comment.
Nice job! A couple things below
Also, rename described_form_group/index.tsx to described_form_group/index.ts
src/components/form/described_form_group/described_form_group.tsx
Outdated
Show resolved
Hide resolved
src/components/form/described_form_group/described_form_group.tsx
Outdated
Show resolved
Hide resolved
thompsongl
suggested changes
Jan 31, 2020
Contributor
thompsongl
left a comment
thompsongl
left a comment
There was a problem hiding this comment.
These 3 all go together. Should be the last necessary changes.
src/components/form/described_form_group/described_form_group.tsx
Outdated
Show resolved
Hide resolved
src/components/form/described_form_group/described_form_group.tsx
Outdated
Show resolved
Hide resolved
src/components/form/described_form_group/described_form_group.tsx
Outdated
Show resolved
Hide resolved
Co-Authored-By: Greg Thompson <thompsongl@users.noreply.github.com>
Co-Authored-By: Greg Thompson <thompsongl@users.noreply.github.com>
Co-Authored-By: Greg Thompson <thompsongl@users.noreply.github.com>
thompsongl
suggested changes
Jan 31, 2020
Contributor
thompsongl
left a comment
thompsongl
left a comment
There was a problem hiding this comment.
Almost! Caught something while checking in Kibana
Need to add the idAria prop to EuiDescribedFormGroupProps: idAria?: string
Contributor
Author
|
@thompsongl the |
thompsongl
approved these changes
Feb 3, 2020
Contributor
thompsongl
left a comment
thompsongl
left a comment
There was a problem hiding this comment.
Ah I missed that. This is good to go, then
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #2649.
This is basically an attempt to convert the
EuiDescribedFormGroupto typescript.Checklist