Adds prepend and append to the EuiColorPicker#2819
Merged
thompsongl merged 8 commits intoelastic:masterfrom Feb 4, 2020
Merged
Adds prepend and append to the EuiColorPicker#2819thompsongl merged 8 commits intoelastic:masterfrom
thompsongl merged 8 commits intoelastic:masterfrom
Conversation
elizabetdev
commented
Feb 3, 2020
cchaos
suggested changes
Feb 3, 2020
Contributor
Author
|
Thanks, @cchaos. I just fixed the border-radius issue: |
thompsongl
approved these changes
Feb 4, 2020
Contributor
thompsongl
left a comment
There was a problem hiding this comment.
LGTM! Thanks for the test
.euiColorPicker__popoverAnchor { ... is still in here. Is this going to change at all?
elizabetdev
commented
Feb 4, 2020
| isOpen={isColorSelectorShown} | ||
| closePopover={handleFinalSelection} | ||
| zIndex={popoverZIndex} | ||
| className={popoverClass} |
Contributor
Author
Contributor
Contributor
cchaos
approved these changes
Feb 4, 2020
Contributor
cchaos
left a comment
There was a problem hiding this comment.
(Certainly possible; it just may be need to be done in a separate issue)
Ok, I'll create an issue. This PR 👍 LGTM!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




Summary
Part of the #2794
This PR adds a prepend and append to the
EuiColorPicker.More toggling options were added into the Forms Color Selection section of the docs.
Checklist