Skip to content

Hide Enterprise search panel when no nodes are present#127100

Merged
matschaffer merged 5 commits intoelastic:mainfrom
matschaffer:issue-121192-hide-entsearch-on-no-data
Mar 8, 2022
Merged

Hide Enterprise search panel when no nodes are present#127100
matschaffer merged 5 commits intoelastic:mainfrom
matschaffer:issue-121192-hide-entsearch-on-no-data

Conversation

@matschaffer
Copy link
Copy Markdown
Contributor

@matschaffer matschaffer commented Mar 8, 2022 •
edited
Loading

Summary

Fixes #121192

The basic hide check was pretty simple. I also updated the overview test to use a positive assertion (via a new getPresentPanels helper).

This should help avoid any future similar oversight when adding stack components.

Checklist

For maintainers

@matschaffer matschaffer added release_note:fix auto-backport Deprecated - use backport:version if exact versions are needed v8.2.0 labels Mar 8, 2022
@matschaffer matschaffer self-assigned this Mar 8, 2022
@matschaffer
Combine overview negative tests into one function
599b647 
Also include enterprise search negative check.
@matschaffer matschaffer added auto-backport Deprecated - use backport:version if exact versions are needed v8.0.2 v8.1.1 and removed auto-backport Deprecated - use backport:version if exact versions are needed labels Mar 8, 2022
@matschaffer matschaffer marked this pull request as ready for review March 8, 2022 04:38
@matschaffer matschaffer requested a review from a team as a code owner March 8, 2022 04:38
@matschaffer
Use positive panel testing instead
af622a2 
This should help ensure we don't have the same problem again of a non-hidden stack component.
@matschaffer
Remove unused does*PanelExist checks
f7f1127
@kibana-ci
Copy link
Copy Markdown

kibana-ci commented Mar 8, 2022

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
monitoring 471.6KB 471.7KB +25.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @matschaffer

@matschaffer matschaffer enabled auto-merge (squash) March 8, 2022 06:43
miltonhultgren
miltonhultgren approved these changes Mar 8, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@miltonhultgren miltonhultgren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍🏼

@matschaffer matschaffer merged commit fc3aedc into elastic:main Mar 8, 2022
@kibanamachine kibanamachine mentioned this pull request Mar 8, 2022
Merged
kibanamachine pushed a commit that referenced this pull request Mar 8, 2022
@matschaffer
Hide Enterprise search panel when no nodes are present (#127100)
ba7127e 
(cherry picked from commit fc3aedc)
kibanamachine pushed a commit that referenced this pull request Mar 8, 2022
@matschaffer
Hide Enterprise search panel when no nodes are present (#127100)
73a993c 
(cherry picked from commit fc3aedc)
@kibanamachine kibanamachine mentioned this pull request Mar 8, 2022
Merged
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Mar 8, 2022

💚 All backports created successfully

Status Branch Result
✅ 8.1
✅ 8.0

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Mar 8, 2022
@kibanamachine @matschaffer
Hide Enterprise search panel when no nodes are present (#127100) (#12…
1765d1d 
…7114)

(cherry picked from commit fc3aedc)

Co-authored-by: Mat Schaffer <mat@elastic.co>
kibanamachine added a commit that referenced this pull request Mar 8, 2022
@kibanamachine @matschaffer
Hide Enterprise search panel when no nodes are present (#127100) (#12…
fa8b280 
…7113)

(cherry picked from commit fc3aedc)

Co-authored-by: Mat Schaffer <mat@elastic.co>
jloleysens added a commit to jloleysens/kibana that referenced this pull request Mar 8, 2022
@jloleysens
Merge branch 'main' of github.com:elastic/kibana into reporting/stopp…
2305470 
…ed-unexpectedly-error

* 'main' of github.com:elastic/kibana: (46 commits)
  Fix copy and pasted renderer user_name test (elastic#126663)
  [Gauge] Vis editors gauge legacy percent mode. (elastic#126318)
  Remove all cases related code from timelines (elastic#127003)
  Hide Enterprise search panel when no nodes are present (elastic#127100)
  [Lens] Fixed flakiness on runtime fields' appearance on the list (elastic#126945)
  [Security Solution][Lists] - Add missing privileges callout to exception lists page (elastic#126874)
  [Security Solution][Lists] - Updates exception flyout edit error messages (elastic#126875)
  [Security Solution][Rules] - Remove rule selection for read only users (elastic#126827)
  Fix session cleanup test (elastic#126966)
  [ftr] implement support for accessing ES through CCS (elastic#126547)
  [type-summarizer] always use normalized paths, fix windows compat (elastic#127055)
  Revert "[ci] Configure hourly pipeline for a small spot instance trial (elastic#126824)"
  Revert "[CI] Expand spot instance trial a bit (elastic#126928)"
  [Alerting] Adding functional tests for alerting and actions telemetry (elastic#126528)
  [Telemetry] Check permissions when requesting telemetry (elastic#126238)
  Don't submit empty seed_urls or sitemap_urls when making a partial crawl request (elastic#126972)
  Remove License Requirement for Enterprise Search App Search Meta Engines (elastic#127046)
  [ML] Adding data recognizer module config cache (elastic#126338)
  skip flaky suite (elastic#126027)
  [Reporting] Improve error logging for rescheduled jobs (elastic#126737)
  ...

# Conflicts:
#	x-pack/plugins/reporting/server/core.ts
#	x-pack/plugins/reporting/server/lib/tasks/execute_report.ts
jloleysens added a commit to jloleysens/kibana that referenced this pull request Mar 8, 2022
@jloleysens
Merge branch 'main' of github.com:elastic/kibana into reporting/captu…
d4c9507 
…re-browser-errors

* 'main' of github.com:elastic/kibana: (46 commits)
  Fix copy and pasted renderer user_name test (elastic#126663)
  [Gauge] Vis editors gauge legacy percent mode. (elastic#126318)
  Remove all cases related code from timelines (elastic#127003)
  Hide Enterprise search panel when no nodes are present (elastic#127100)
  [Lens] Fixed flakiness on runtime fields' appearance on the list (elastic#126945)
  [Security Solution][Lists] - Add missing privileges callout to exception lists page (elastic#126874)
  [Security Solution][Lists] - Updates exception flyout edit error messages (elastic#126875)
  [Security Solution][Rules] - Remove rule selection for read only users (elastic#126827)
  Fix session cleanup test (elastic#126966)
  [ftr] implement support for accessing ES through CCS (elastic#126547)
  [type-summarizer] always use normalized paths, fix windows compat (elastic#127055)
  Revert "[ci] Configure hourly pipeline for a small spot instance trial (elastic#126824)"
  Revert "[CI] Expand spot instance trial a bit (elastic#126928)"
  [Alerting] Adding functional tests for alerting and actions telemetry (elastic#126528)
  [Telemetry] Check permissions when requesting telemetry (elastic#126238)
  Don't submit empty seed_urls or sitemap_urls when making a partial crawl request (elastic#126972)
  Remove License Requirement for Enterprise Search App Search Meta Engines (elastic#127046)
  [ML] Adding data recognizer module config cache (elastic#126338)
  skip flaky suite (elastic#126027)
  [Reporting] Improve error logging for rescheduled jobs (elastic#126737)
  ...

# Conflicts:
#	x-pack/plugins/reporting/server/lib/tasks/execute_report.ts
@matschaffer matschaffer deleted the issue-121192-hide-entsearch-on-no-data branch March 9, 2022 01:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@miltonhultgren miltonhultgren miltonhultgren approved these changes

Assignees

@matschaffer matschaffer

Labels

auto-backport Deprecated - use backport:version if exact versions are needed release_note:fix Team:EnterpriseSearch v8.0.2 v8.1.1 v8.2.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Stack Monitoring] Enterprise search module showing up in Cluster overview with no data

5 participants

@matschaffer @kibana-ci @kibanamachine @miltonhultgren @KOTungseth