Skip to content

[Lens] Fixed flakiness on runtime fields' appearance on the list#126945

Merged
stratoula merged 2 commits intoelastic:mainfrom
stratoula:runtime-lens-flaky
Mar 8, 2022
Merged

[Lens] Fixed flakiness on runtime fields' appearance on the list#126945
stratoula merged 2 commits intoelastic:mainfrom
stratoula:runtime-lens-flaky

Conversation

@stratoula
Copy link
Copy Markdown
Contributor

@stratoula stratoula commented Mar 4, 2022 •
edited
Loading

Summary

Closes #107854

I think that this is caused due to a race condition. We are searching for the runtime field before it is actually inserted and this the reason it doesn't appear on the list. I think a waitUntilLoadingHasFinished will make it more stable. I run it 300 times and hasn't failed.

Flaky runners

100 times https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/213
100 times https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/228
100 times https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/229

Checklist

@stratoula stratoula added failed-test A test failure on a tracked branch, potentially flaky-test Feature:Lens release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Team label for Lens, elastic-charts, Graph, legacy editors (TSVB, Visualize, Timelion) t// v8.1.0 v8.2.0 auto-backport Deprecated - use backport:version if exact versions are needed labels Mar 7, 2022
@stratoula stratoula marked this pull request as ready for review March 7, 2022 16:39
@stratoula stratoula requested a review from a team as a code owner March 7, 2022 16:39
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Mar 7, 2022

Pinging @elastic/kibana-vis-editors @elastic/kibana-vis-editors-external (Team:VisEditors)

flash1293
flash1293 approved these changes Mar 7, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@flash1293 flash1293 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM

@kibana-ci
Copy link
Copy Markdown

kibana-ci commented Mar 7, 2022

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@stratoula stratoula merged commit 962347f into elastic:main Mar 8, 2022
@kibanamachine kibanamachine mentioned this pull request Mar 8, 2022
Merged
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Mar 8, 2022

💚 All backports created successfully

Status Branch Result
✅ 8.1

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine pushed a commit that referenced this pull request Mar 8, 2022
@stratoula
[Lens] Fixed flakiness on runtime fields' appearance on the list (#12…
ec765ac 
…6945)

(cherry picked from commit 962347f)
kibanamachine added a commit that referenced this pull request Mar 8, 2022
@kibanamachine @stratoula
[Lens] Fixed flakiness on runtime fields' appearance on the list (#12…
585aa8b 
…6945) (#127109)

(cherry picked from commit 962347f)

Co-authored-by: Stratoula Kalafateli <efstratia.kalafateli@elastic.co>
jloleysens added a commit to jloleysens/kibana that referenced this pull request Mar 8, 2022
@jloleysens
Merge branch 'main' of github.com:elastic/kibana into reporting/stopp…
2305470 
…ed-unexpectedly-error

* 'main' of github.com:elastic/kibana: (46 commits)
  Fix copy and pasted renderer user_name test (elastic#126663)
  [Gauge] Vis editors gauge legacy percent mode. (elastic#126318)
  Remove all cases related code from timelines (elastic#127003)
  Hide Enterprise search panel when no nodes are present (elastic#127100)
  [Lens] Fixed flakiness on runtime fields' appearance on the list (elastic#126945)
  [Security Solution][Lists] - Add missing privileges callout to exception lists page (elastic#126874)
  [Security Solution][Lists] - Updates exception flyout edit error messages (elastic#126875)
  [Security Solution][Rules] - Remove rule selection for read only users (elastic#126827)
  Fix session cleanup test (elastic#126966)
  [ftr] implement support for accessing ES through CCS (elastic#126547)
  [type-summarizer] always use normalized paths, fix windows compat (elastic#127055)
  Revert "[ci] Configure hourly pipeline for a small spot instance trial (elastic#126824)"
  Revert "[CI] Expand spot instance trial a bit (elastic#126928)"
  [Alerting] Adding functional tests for alerting and actions telemetry (elastic#126528)
  [Telemetry] Check permissions when requesting telemetry (elastic#126238)
  Don't submit empty seed_urls or sitemap_urls when making a partial crawl request (elastic#126972)
  Remove License Requirement for Enterprise Search App Search Meta Engines (elastic#127046)
  [ML] Adding data recognizer module config cache (elastic#126338)
  skip flaky suite (elastic#126027)
  [Reporting] Improve error logging for rescheduled jobs (elastic#126737)
  ...

# Conflicts:
#	x-pack/plugins/reporting/server/core.ts
#	x-pack/plugins/reporting/server/lib/tasks/execute_report.ts
jloleysens added a commit to jloleysens/kibana that referenced this pull request Mar 8, 2022
@jloleysens
Merge branch 'main' of github.com:elastic/kibana into reporting/captu…
d4c9507 
…re-browser-errors

* 'main' of github.com:elastic/kibana: (46 commits)
  Fix copy and pasted renderer user_name test (elastic#126663)
  [Gauge] Vis editors gauge legacy percent mode. (elastic#126318)
  Remove all cases related code from timelines (elastic#127003)
  Hide Enterprise search panel when no nodes are present (elastic#127100)
  [Lens] Fixed flakiness on runtime fields' appearance on the list (elastic#126945)
  [Security Solution][Lists] - Add missing privileges callout to exception lists page (elastic#126874)
  [Security Solution][Lists] - Updates exception flyout edit error messages (elastic#126875)
  [Security Solution][Rules] - Remove rule selection for read only users (elastic#126827)
  Fix session cleanup test (elastic#126966)
  [ftr] implement support for accessing ES through CCS (elastic#126547)
  [type-summarizer] always use normalized paths, fix windows compat (elastic#127055)
  Revert "[ci] Configure hourly pipeline for a small spot instance trial (elastic#126824)"
  Revert "[CI] Expand spot instance trial a bit (elastic#126928)"
  [Alerting] Adding functional tests for alerting and actions telemetry (elastic#126528)
  [Telemetry] Check permissions when requesting telemetry (elastic#126238)
  Don't submit empty seed_urls or sitemap_urls when making a partial crawl request (elastic#126972)
  Remove License Requirement for Enterprise Search App Search Meta Engines (elastic#127046)
  [ML] Adding data recognizer module config cache (elastic#126338)
  skip flaky suite (elastic#126027)
  [Reporting] Improve error logging for rescheduled jobs (elastic#126737)
  ...

# Conflicts:
#	x-pack/plugins/reporting/server/lib/tasks/execute_report.ts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@flash1293 flash1293 flash1293 approved these changes

@mbondyra mbondyra mbondyra approved these changes

Assignees

No one assigned

Labels

auto-backport Deprecated - use backport:version if exact versions are needed failed-test A test failure on a tracked branch, potentially flaky-test Feature:Lens release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Team label for Lens, elastic-charts, Graph, legacy editors (TSVB, Visualize, Timelion) t// v8.1.0 v8.2.0

Projects

None yet

Milestone

No milestone

6 participants

@stratoula @elasticmachine @kibana-ci @kibanamachine @flash1293 @mbondyra