Skip to content

[Alerting] Adding functional tests for alerting and actions telemetry#126528

Merged
ymao1 merged 14 commits intoelastic:mainfrom
ymao1:alerting/telemetry-tests-2
Mar 7, 2022
Merged

[Alerting] Adding functional tests for alerting and actions telemetry#126528
ymao1 merged 14 commits intoelastic:mainfrom
ymao1:alerting/telemetry-tests-2

Conversation

@ymao1
Copy link
Copy Markdown
Contributor

@ymao1 ymao1 commented Feb 28, 2022 •
edited
Loading

Resolves #123272

Summary

  • Added functional tests for alerting and actions that create rules & connectors, lets them run for a bit, then triggers the alerting telemetry task and verifies that the task succeeded and the calculated telemetry is as expected
  • Renamed getTestAlertData fn to getTestRuleData which is why there are so many files changed in this PR

@ymao1 ymao1 changed the title Alerting/telemetry tests 2 [Alerting] Adding functional tests for alerting and actions telemetry Mar 2, 2022
@ymao1 ymao1 self-assigned this Mar 2, 2022
@ymao1 ymao1 added backport:skip This PR does not require backporting Feature:Alerting/RulesFramework Issues related to the Alerting Rules Framework release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Platform ResponseOps team (formerly the Cases and Alerting teams) t// v8.2.0 labels Mar 2, 2022
@ymao1 ymao1 marked this pull request as ready for review March 2, 2022 22:57
@ymao1 ymao1 requested a review from a team as a code owner March 2, 2022 22:57
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Mar 2, 2022

Pinging @elastic/response-ops (Team:ResponseOps)

@mikecote mikecote self-requested a review March 4, 2022 21:39
@ymao1
Copy link
Copy Markdown
Contributor Author

ymao1 commented Mar 7, 2022

@elasticmachine merge upstream

ersin-erdal
ersin-erdal approved these changes Mar 7, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@ersin-erdal ersin-erdal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@kibana-ci
Copy link
Copy Markdown

kibana-ci commented Mar 7, 2022

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @ymao1

mikecote
mikecote approved these changes Mar 7, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@mikecote mikecote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM!

@ymao1 ymao1 merged commit c0a653d into elastic:main Mar 7, 2022
@ymao1 ymao1 deleted the alerting/telemetry-tests-2 branch March 7, 2022 20:35
jloleysens added a commit to jloleysens/kibana that referenced this pull request Mar 8, 2022
@jloleysens
Merge branch 'main' of github.com:elastic/kibana into reporting/stopp…
2305470 
…ed-unexpectedly-error

* 'main' of github.com:elastic/kibana: (46 commits)
  Fix copy and pasted renderer user_name test (elastic#126663)
  [Gauge] Vis editors gauge legacy percent mode. (elastic#126318)
  Remove all cases related code from timelines (elastic#127003)
  Hide Enterprise search panel when no nodes are present (elastic#127100)
  [Lens] Fixed flakiness on runtime fields' appearance on the list (elastic#126945)
  [Security Solution][Lists] - Add missing privileges callout to exception lists page (elastic#126874)
  [Security Solution][Lists] - Updates exception flyout edit error messages (elastic#126875)
  [Security Solution][Rules] - Remove rule selection for read only users (elastic#126827)
  Fix session cleanup test (elastic#126966)
  [ftr] implement support for accessing ES through CCS (elastic#126547)
  [type-summarizer] always use normalized paths, fix windows compat (elastic#127055)
  Revert "[ci] Configure hourly pipeline for a small spot instance trial (elastic#126824)"
  Revert "[CI] Expand spot instance trial a bit (elastic#126928)"
  [Alerting] Adding functional tests for alerting and actions telemetry (elastic#126528)
  [Telemetry] Check permissions when requesting telemetry (elastic#126238)
  Don't submit empty seed_urls or sitemap_urls when making a partial crawl request (elastic#126972)
  Remove License Requirement for Enterprise Search App Search Meta Engines (elastic#127046)
  [ML] Adding data recognizer module config cache (elastic#126338)
  skip flaky suite (elastic#126027)
  [Reporting] Improve error logging for rescheduled jobs (elastic#126737)
  ...

# Conflicts:
#	x-pack/plugins/reporting/server/core.ts
#	x-pack/plugins/reporting/server/lib/tasks/execute_report.ts
jloleysens added a commit to jloleysens/kibana that referenced this pull request Mar 8, 2022
@jloleysens
Merge branch 'main' of github.com:elastic/kibana into reporting/captu…
d4c9507 
…re-browser-errors

* 'main' of github.com:elastic/kibana: (46 commits)
  Fix copy and pasted renderer user_name test (elastic#126663)
  [Gauge] Vis editors gauge legacy percent mode. (elastic#126318)
  Remove all cases related code from timelines (elastic#127003)
  Hide Enterprise search panel when no nodes are present (elastic#127100)
  [Lens] Fixed flakiness on runtime fields' appearance on the list (elastic#126945)
  [Security Solution][Lists] - Add missing privileges callout to exception lists page (elastic#126874)
  [Security Solution][Lists] - Updates exception flyout edit error messages (elastic#126875)
  [Security Solution][Rules] - Remove rule selection for read only users (elastic#126827)
  Fix session cleanup test (elastic#126966)
  [ftr] implement support for accessing ES through CCS (elastic#126547)
  [type-summarizer] always use normalized paths, fix windows compat (elastic#127055)
  Revert "[ci] Configure hourly pipeline for a small spot instance trial (elastic#126824)"
  Revert "[CI] Expand spot instance trial a bit (elastic#126928)"
  [Alerting] Adding functional tests for alerting and actions telemetry (elastic#126528)
  [Telemetry] Check permissions when requesting telemetry (elastic#126238)
  Don't submit empty seed_urls or sitemap_urls when making a partial crawl request (elastic#126972)
  Remove License Requirement for Enterprise Search App Search Meta Engines (elastic#127046)
  [ML] Adding data recognizer module config cache (elastic#126338)
  skip flaky suite (elastic#126027)
  [Reporting] Improve error logging for rescheduled jobs (elastic#126737)
  ...

# Conflicts:
#	x-pack/plugins/reporting/server/lib/tasks/execute_report.ts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mikecote mikecote mikecote approved these changes

@ersin-erdal ersin-erdal ersin-erdal approved these changes

Assignees

@ymao1 ymao1

Labels

backport:skip This PR does not require backporting Feature:Alerting/RulesFramework Issues related to the Alerting Rules Framework release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Platform ResponseOps team (formerly the Cases and Alerting teams) t// v8.2.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Alerting][Telemetry] Improve functional tests for telemetry collection

6 participants

@ymao1 @elasticmachine @kibana-ci @mikecote @ersin-erdal @kibanamachine