Skip to content

[Security Solution][Lists] - Updates exception flyout edit error messages#126875

Merged
yctercero merged 4 commits intoelastic:mainfrom
yctercero:126669
Mar 8, 2022
Merged

[Security Solution][Lists] - Updates exception flyout edit error messages#126875
yctercero merged 4 commits intoelastic:mainfrom
yctercero:126669

Conversation

@yctercero
Copy link
Copy Markdown
Contributor

@yctercero yctercero commented Mar 4, 2022 •
edited
Loading

Summary

Addresses #126669

Error messages on flyout were being truncated/were out of view.

Version conflict

Screen Shot 2022-03-03 at 7 09 07 PM

Exception list container or item no longer exists

Screen Shot 2022-03-03 at 7 13 10 PM

Checklist

@yctercero
Copy link
Copy Markdown
Contributor Author

yctercero commented Mar 6, 2022

@elasticmachine merge upstream

@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Mar 6, 2022

expected head sha didn’t match current head ref.

@yctercero yctercero self-assigned this Mar 8, 2022
@yctercero yctercero added bug Fixes for quality problems that affect the customer experience release_note:fix Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Detections and Resp Security Detection Response Team Team:Security Solution Platform v8.1.1 v8.2.0 auto-backport Deprecated - use backport:version if exact versions are needed labels Mar 8, 2022
@yctercero yctercero marked this pull request as ready for review March 8, 2022 02:35
@yctercero yctercero requested a review from a team as a code owner March 8, 2022 02:35
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Mar 8, 2022

Pinging @elastic/security-detections-response (Team:Detections and Resp)

@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Mar 8, 2022

Pinging @elastic/security-solution (Team: SecuritySolution)

dplumlee
dplumlee approved these changes Mar 8, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@dplumlee dplumlee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked it out and works locally! 👍

@yctercero yctercero enabled auto-merge (squash) March 8, 2022 03:56
@kibana-ci
Copy link
Copy Markdown

kibana-ci commented Mar 8, 2022

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 4.7MB 4.7MB +126.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @yctercero

@yctercero yctercero merged commit 50ba761 into elastic:main Mar 8, 2022
kibanamachine pushed a commit that referenced this pull request Mar 8, 2022
@yctercero
[Security Solution][Lists] - Updates exception flyout edit error mess…
71bc97d 
…ages (#126875)

Addresses #126669

Error messages on flyout were being truncated/were out of view.

(cherry picked from commit 50ba761)
@kibanamachine kibanamachine mentioned this pull request Mar 8, 2022
Merged
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Mar 8, 2022

💚 All backports created successfully

Status Branch Result
✅ 8.1

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

@yctercero yctercero deleted the 126669 branch March 8, 2022 05:31
jloleysens added a commit to jloleysens/kibana that referenced this pull request Mar 8, 2022
@jloleysens
Merge branch 'main' of github.com:elastic/kibana into reporting/stopp…
2305470 
…ed-unexpectedly-error

* 'main' of github.com:elastic/kibana: (46 commits)
  Fix copy and pasted renderer user_name test (elastic#126663)
  [Gauge] Vis editors gauge legacy percent mode. (elastic#126318)
  Remove all cases related code from timelines (elastic#127003)
  Hide Enterprise search panel when no nodes are present (elastic#127100)
  [Lens] Fixed flakiness on runtime fields' appearance on the list (elastic#126945)
  [Security Solution][Lists] - Add missing privileges callout to exception lists page (elastic#126874)
  [Security Solution][Lists] - Updates exception flyout edit error messages (elastic#126875)
  [Security Solution][Rules] - Remove rule selection for read only users (elastic#126827)
  Fix session cleanup test (elastic#126966)
  [ftr] implement support for accessing ES through CCS (elastic#126547)
  [type-summarizer] always use normalized paths, fix windows compat (elastic#127055)
  Revert "[ci] Configure hourly pipeline for a small spot instance trial (elastic#126824)"
  Revert "[CI] Expand spot instance trial a bit (elastic#126928)"
  [Alerting] Adding functional tests for alerting and actions telemetry (elastic#126528)
  [Telemetry] Check permissions when requesting telemetry (elastic#126238)
  Don't submit empty seed_urls or sitemap_urls when making a partial crawl request (elastic#126972)
  Remove License Requirement for Enterprise Search App Search Meta Engines (elastic#127046)
  [ML] Adding data recognizer module config cache (elastic#126338)
  skip flaky suite (elastic#126027)
  [Reporting] Improve error logging for rescheduled jobs (elastic#126737)
  ...

# Conflicts:
#	x-pack/plugins/reporting/server/core.ts
#	x-pack/plugins/reporting/server/lib/tasks/execute_report.ts
jloleysens added a commit to jloleysens/kibana that referenced this pull request Mar 8, 2022
@jloleysens
Merge branch 'main' of github.com:elastic/kibana into reporting/captu…
d4c9507 
…re-browser-errors

* 'main' of github.com:elastic/kibana: (46 commits)
  Fix copy and pasted renderer user_name test (elastic#126663)
  [Gauge] Vis editors gauge legacy percent mode. (elastic#126318)
  Remove all cases related code from timelines (elastic#127003)
  Hide Enterprise search panel when no nodes are present (elastic#127100)
  [Lens] Fixed flakiness on runtime fields' appearance on the list (elastic#126945)
  [Security Solution][Lists] - Add missing privileges callout to exception lists page (elastic#126874)
  [Security Solution][Lists] - Updates exception flyout edit error messages (elastic#126875)
  [Security Solution][Rules] - Remove rule selection for read only users (elastic#126827)
  Fix session cleanup test (elastic#126966)
  [ftr] implement support for accessing ES through CCS (elastic#126547)
  [type-summarizer] always use normalized paths, fix windows compat (elastic#127055)
  Revert "[ci] Configure hourly pipeline for a small spot instance trial (elastic#126824)"
  Revert "[CI] Expand spot instance trial a bit (elastic#126928)"
  [Alerting] Adding functional tests for alerting and actions telemetry (elastic#126528)
  [Telemetry] Check permissions when requesting telemetry (elastic#126238)
  Don't submit empty seed_urls or sitemap_urls when making a partial crawl request (elastic#126972)
  Remove License Requirement for Enterprise Search App Search Meta Engines (elastic#127046)
  [ML] Adding data recognizer module config cache (elastic#126338)
  skip flaky suite (elastic#126027)
  [Reporting] Improve error logging for rescheduled jobs (elastic#126737)
  ...

# Conflicts:
#	x-pack/plugins/reporting/server/lib/tasks/execute_report.ts
@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Mar 10, 2022
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Mar 10, 2022

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

2 similar comments
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Mar 11, 2022

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Mar 14, 2022

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Mar 15, 2022
kibanamachine added a commit that referenced this pull request Mar 15, 2022
@kibanamachine @yctercero
[Security Solution][Lists] - Updates exception flyout edit error mess…
691cbcd 
…ages (#126875) (#127099)

Addresses #126669

Error messages on flyout were being truncated/were out of view.

(cherry picked from commit 50ba761)

Co-authored-by: Yara Tercero <yctercero@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dplumlee dplumlee dplumlee approved these changes

Assignees

@yctercero yctercero

Labels

auto-backport Deprecated - use backport:version if exact versions are needed bug Fixes for quality problems that affect the customer experience release_note:fix Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v8.1.1 v8.2.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@yctercero @kibanamachine @elasticmachine @kibana-ci @dplumlee