Skip to content

Remove License Requirement for Enterprise Search App Search Meta Engines#127046

Merged
markjhoy merged 2 commits intoelastic:mainfrom
markjhoy:markjhoy/remove_ent-search_meta_engine_license
Mar 7, 2022
Merged

Remove License Requirement for Enterprise Search App Search Meta Engines#127046
markjhoy merged 2 commits intoelastic:mainfrom
markjhoy:markjhoy/remove_ent-search_meta_engine_license

Conversation

@markjhoy
Copy link
Copy Markdown
Contributor

@markjhoy markjhoy commented Mar 7, 2022

Summary

As part of changes to Enterprise Search / App Search meta engines, we are removing the license requirement for 8.2.0. This PR removes the constraint (and also updates the unit test for it). The back-end work for this has already been completed under https://github.com/elastic/ent-search/pull/6247

Checklist

@markjhoy markjhoy requested a review from a team March 7, 2022 16:40
scottybollinger
scottybollinger approved these changes Mar 7, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@scottybollinger scottybollinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for knocking this out!

@scottybollinger
Copy link
Copy Markdown
Contributor

scottybollinger commented Mar 7, 2022

Created a follow-up issue to clean up the UI elements that are no longer rendered as a result of this PR.

@kibana-ci
Copy link
Copy Markdown

kibana-ci commented Mar 7, 2022

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
enterpriseSearch 1.4MB 1.4MB -3.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@markjhoy markjhoy merged commit de3ae9b into elastic:main Mar 7, 2022
jloleysens added a commit to jloleysens/kibana that referenced this pull request Mar 8, 2022
@jloleysens
Merge branch 'main' of github.com:elastic/kibana into reporting/stopp…
2305470 
…ed-unexpectedly-error

* 'main' of github.com:elastic/kibana: (46 commits)
  Fix copy and pasted renderer user_name test (elastic#126663)
  [Gauge] Vis editors gauge legacy percent mode. (elastic#126318)
  Remove all cases related code from timelines (elastic#127003)
  Hide Enterprise search panel when no nodes are present (elastic#127100)
  [Lens] Fixed flakiness on runtime fields' appearance on the list (elastic#126945)
  [Security Solution][Lists] - Add missing privileges callout to exception lists page (elastic#126874)
  [Security Solution][Lists] - Updates exception flyout edit error messages (elastic#126875)
  [Security Solution][Rules] - Remove rule selection for read only users (elastic#126827)
  Fix session cleanup test (elastic#126966)
  [ftr] implement support for accessing ES through CCS (elastic#126547)
  [type-summarizer] always use normalized paths, fix windows compat (elastic#127055)
  Revert "[ci] Configure hourly pipeline for a small spot instance trial (elastic#126824)"
  Revert "[CI] Expand spot instance trial a bit (elastic#126928)"
  [Alerting] Adding functional tests for alerting and actions telemetry (elastic#126528)
  [Telemetry] Check permissions when requesting telemetry (elastic#126238)
  Don't submit empty seed_urls or sitemap_urls when making a partial crawl request (elastic#126972)
  Remove License Requirement for Enterprise Search App Search Meta Engines (elastic#127046)
  [ML] Adding data recognizer module config cache (elastic#126338)
  skip flaky suite (elastic#126027)
  [Reporting] Improve error logging for rescheduled jobs (elastic#126737)
  ...

# Conflicts:
#	x-pack/plugins/reporting/server/core.ts
#	x-pack/plugins/reporting/server/lib/tasks/execute_report.ts
jloleysens added a commit to jloleysens/kibana that referenced this pull request Mar 8, 2022
@jloleysens
Merge branch 'main' of github.com:elastic/kibana into reporting/captu…
d4c9507 
…re-browser-errors

* 'main' of github.com:elastic/kibana: (46 commits)
  Fix copy and pasted renderer user_name test (elastic#126663)
  [Gauge] Vis editors gauge legacy percent mode. (elastic#126318)
  Remove all cases related code from timelines (elastic#127003)
  Hide Enterprise search panel when no nodes are present (elastic#127100)
  [Lens] Fixed flakiness on runtime fields' appearance on the list (elastic#126945)
  [Security Solution][Lists] - Add missing privileges callout to exception lists page (elastic#126874)
  [Security Solution][Lists] - Updates exception flyout edit error messages (elastic#126875)
  [Security Solution][Rules] - Remove rule selection for read only users (elastic#126827)
  Fix session cleanup test (elastic#126966)
  [ftr] implement support for accessing ES through CCS (elastic#126547)
  [type-summarizer] always use normalized paths, fix windows compat (elastic#127055)
  Revert "[ci] Configure hourly pipeline for a small spot instance trial (elastic#126824)"
  Revert "[CI] Expand spot instance trial a bit (elastic#126928)"
  [Alerting] Adding functional tests for alerting and actions telemetry (elastic#126528)
  [Telemetry] Check permissions when requesting telemetry (elastic#126238)
  Don't submit empty seed_urls or sitemap_urls when making a partial crawl request (elastic#126972)
  Remove License Requirement for Enterprise Search App Search Meta Engines (elastic#127046)
  [ML] Adding data recognizer module config cache (elastic#126338)
  skip flaky suite (elastic#126027)
  [Reporting] Improve error logging for rescheduled jobs (elastic#126737)
  ...

# Conflicts:
#	x-pack/plugins/reporting/server/lib/tasks/execute_report.ts
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Mar 9, 2022

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 127046 or prevent reminders by adding the backport:skip label.

@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Mar 9, 2022
@scottybollinger scottybollinger added auto-backport Deprecated - use backport:version if exact versions are needed and removed backport missing Added to PRs automatically when the are determined to be missing a backport. labels Mar 9, 2022
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Mar 9, 2022

⚪ Backport skipped

The pull request was not backported as there were no branches to backport to. If this is a mistake, please apply the desired version labels or run the backport tool manually.

Manual backport

To create the backport manually run:

node scripts/backport --pr 127046

Questions ?

Please refer to the Backport tool documentation

@scottybollinger scottybollinger added backport:skip This PR does not require backporting and removed auto-backport Deprecated - use backport:version if exact versions are needed labels Mar 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@scottybollinger scottybollinger scottybollinger approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

8.2 candidate backport:skip This PR does not require backporting release_note:enhancement Team:EnterpriseSearch v8.2.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@markjhoy @scottybollinger @kibana-ci @kibanamachine @KOTungseth