Skip to content

Remove all cases related code from timelines#127003

Merged
academo merged 6 commits intoelastic:mainfrom
academo:refactor/timelines-delete-cases-dead-code
Mar 8, 2022
Merged

Remove all cases related code from timelines#127003
academo merged 6 commits intoelastic:mainfrom
academo:refactor/timelines-delete-cases-dead-code

Conversation

@academo
Copy link
Copy Markdown
Contributor

@academo academo commented Mar 7, 2022 •
edited
Loading

Summary

See epic: #123183

Follow up to #126265

After merging #126265, the code inside timelines that handles the "add to new case" and "add to existing" is not longer in use (dead code) and should be removed.

This PR removes the code, mocks, types and any leftover usage in the code base for it.

Closes #125658
Closes #126264
Closes #125761

@academo academo added release_note:skip Skip the PR/issue when compiling release notes backport:skip This PR does not require backporting Team:ResponseOps Platform ResponseOps team (formerly the Cases and Alerting teams) t// Feature:Cases Cases feature v8.2.0 labels Mar 7, 2022
@academo academo self-assigned this Mar 7, 2022
@academo academo marked this pull request as ready for review March 7, 2022 14:37
@academo academo requested review from a team as code owners March 7, 2022 14:37
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Mar 7, 2022

Pinging @elastic/response-ops (Team:ResponseOps)

@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Mar 7, 2022

Pinging @elastic/response-ops-cases (Feature:Cases)

@academo academo requested a review from peteharverson March 7, 2022 14:37
kqualters-elastic
kqualters-elastic approved these changes Mar 7, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@kqualters-elastic kqualters-elastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

beautiful 👍

semd
semd approved these changes Mar 7, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@semd semd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+2 −1,420

giphy
LGTM

@kibana-ci
Copy link
Copy Markdown

kibana-ci commented Mar 7, 2022

💛 Build succeeded, but was flaky

Test Failures

  • [job] [logs] Security Solution Tests / Detections > Need Admin Callouts indicating an admin is needed to migrate the alert data set The users index_mapping_outdated is "true" and their admin callouts should show up On Detections home page We show the need admin primary callout
  • [job] [logs] Security Solution Tests / Detections > Need Admin Callouts indicating an admin is needed to migrate the alert data set The users index_mapping_outdated is "true" and their admin callouts should show up On Rules Management page We show 1 primary callout of need admin

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
timelines 282 273 -9

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
timelines 341 331 -10

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
timelines 30.6KB 26.1KB -4.5KB

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id before after diff
timelines 36 35 -1

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
timelines 295.3KB 285.2KB -10.1KB
Unknown metric groups

API count

id before after diff
timelines 445 435 -10

async chunk count

id before after diff
timelines 10 7 -3

ESLint disabled line counts

id before after diff
timelines 51 42 -9

Total ESLint disabled count

id before after diff
timelines 54 45 -9

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @academo

cnasikas
cnasikas approved these changes Mar 8, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@cnasikas cnasikas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing! 🚀

@academo academo merged commit 5ad355e into elastic:main Mar 8, 2022
@academo academo deleted the refactor/timelines-delete-cases-dead-code branch March 8, 2022 08:01
jloleysens added a commit to jloleysens/kibana that referenced this pull request Mar 8, 2022
@jloleysens
Merge branch 'main' of github.com:elastic/kibana into reporting/stopp…
2305470 
…ed-unexpectedly-error

* 'main' of github.com:elastic/kibana: (46 commits)
  Fix copy and pasted renderer user_name test (elastic#126663)
  [Gauge] Vis editors gauge legacy percent mode. (elastic#126318)
  Remove all cases related code from timelines (elastic#127003)
  Hide Enterprise search panel when no nodes are present (elastic#127100)
  [Lens] Fixed flakiness on runtime fields' appearance on the list (elastic#126945)
  [Security Solution][Lists] - Add missing privileges callout to exception lists page (elastic#126874)
  [Security Solution][Lists] - Updates exception flyout edit error messages (elastic#126875)
  [Security Solution][Rules] - Remove rule selection for read only users (elastic#126827)
  Fix session cleanup test (elastic#126966)
  [ftr] implement support for accessing ES through CCS (elastic#126547)
  [type-summarizer] always use normalized paths, fix windows compat (elastic#127055)
  Revert "[ci] Configure hourly pipeline for a small spot instance trial (elastic#126824)"
  Revert "[CI] Expand spot instance trial a bit (elastic#126928)"
  [Alerting] Adding functional tests for alerting and actions telemetry (elastic#126528)
  [Telemetry] Check permissions when requesting telemetry (elastic#126238)
  Don't submit empty seed_urls or sitemap_urls when making a partial crawl request (elastic#126972)
  Remove License Requirement for Enterprise Search App Search Meta Engines (elastic#127046)
  [ML] Adding data recognizer module config cache (elastic#126338)
  skip flaky suite (elastic#126027)
  [Reporting] Improve error logging for rescheduled jobs (elastic#126737)
  ...

# Conflicts:
#	x-pack/plugins/reporting/server/core.ts
#	x-pack/plugins/reporting/server/lib/tasks/execute_report.ts
jloleysens added a commit to jloleysens/kibana that referenced this pull request Mar 8, 2022
@jloleysens
Merge branch 'main' of github.com:elastic/kibana into reporting/captu…
d4c9507 
…re-browser-errors

* 'main' of github.com:elastic/kibana: (46 commits)
  Fix copy and pasted renderer user_name test (elastic#126663)
  [Gauge] Vis editors gauge legacy percent mode. (elastic#126318)
  Remove all cases related code from timelines (elastic#127003)
  Hide Enterprise search panel when no nodes are present (elastic#127100)
  [Lens] Fixed flakiness on runtime fields' appearance on the list (elastic#126945)
  [Security Solution][Lists] - Add missing privileges callout to exception lists page (elastic#126874)
  [Security Solution][Lists] - Updates exception flyout edit error messages (elastic#126875)
  [Security Solution][Rules] - Remove rule selection for read only users (elastic#126827)
  Fix session cleanup test (elastic#126966)
  [ftr] implement support for accessing ES through CCS (elastic#126547)
  [type-summarizer] always use normalized paths, fix windows compat (elastic#127055)
  Revert "[ci] Configure hourly pipeline for a small spot instance trial (elastic#126824)"
  Revert "[CI] Expand spot instance trial a bit (elastic#126928)"
  [Alerting] Adding functional tests for alerting and actions telemetry (elastic#126528)
  [Telemetry] Check permissions when requesting telemetry (elastic#126238)
  Don't submit empty seed_urls or sitemap_urls when making a partial crawl request (elastic#126972)
  Remove License Requirement for Enterprise Search App Search Meta Engines (elastic#127046)
  [ML] Adding data recognizer module config cache (elastic#126338)
  skip flaky suite (elastic#126027)
  [Reporting] Improve error logging for rescheduled jobs (elastic#126737)
  ...

# Conflicts:
#	x-pack/plugins/reporting/server/lib/tasks/execute_report.ts
@academo academo mentioned this pull request Mar 9, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cnasikas cnasikas cnasikas approved these changes

@semd semd semd approved these changes

@kqualters-elastic kqualters-elastic kqualters-elastic approved these changes

@XavierM XavierM Awaiting requested review from XavierM

@mgiota mgiota Awaiting requested review from mgiota

@peteharverson peteharverson Awaiting requested review from peteharverson

Assignees

@academo academo

Labels

backport:skip This PR does not require backporting Feature:Cases Cases feature release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Platform ResponseOps team (formerly the Cases and Alerting teams) t// v8.2.0

Projects

None yet

Milestone

No milestone

6 participants

@academo @elasticmachine @kibana-ci @cnasikas @semd @kqualters-elastic