Skip to content

[Security Solution][Lists] - Add missing privileges callout to exception lists page#126874

Merged
yctercero merged 4 commits intoelastic:mainfrom
yctercero:126330
Mar 8, 2022
Merged

[Security Solution][Lists] - Add missing privileges callout to exception lists page#126874
yctercero merged 4 commits intoelastic:mainfrom
yctercero:126330

Conversation

@yctercero
Copy link
Copy Markdown
Contributor

@yctercero yctercero commented Mar 4, 2022 •
edited
Loading

Summary

Resolves #126330

✅ Kibana read only 🔴 lists index privileges

Screen Shot 2022-03-03 at 11 04 35 AM

✅ Kibana READ only 🟢 lists index privileges

Screen Shot 2022-03-03 at 11 05 23 AM

✅ Kibana ALL 🔴 lists index privileges

Screen Shot 2022-03-03 at 11 06 08 AM

✅ Kibana ALL 🟢 lists index privileges

Screen Shot 2022-03-03 at 11 06 25 AM

Checklist

@yctercero yctercero added Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. auto-backport Deprecated - use backport:version if exact versions are needed v8.1.0 Team:Security Solution Platform v8.2.0 v8.1.1 labels Mar 4, 2022
@yctercero yctercero self-assigned this Mar 4, 2022
@yctercero yctercero requested a review from a team as a code owner March 4, 2022 02:36
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Mar 4, 2022

Pinging @elastic/security-detections-response (Team:Detections and Resp)

@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Mar 4, 2022

Pinging @elastic/security-solution (Team: SecuritySolution)

@yctercero yctercero added release_note:fix bug Fixes for quality problems that affect the customer experience and removed v8.1.0 labels Mar 8, 2022
@yctercero yctercero enabled auto-merge (squash) March 8, 2022 03:55
@yctercero yctercero merged commit e86d7ae into elastic:main Mar 8, 2022
@kibana-ci
Copy link
Copy Markdown

kibana-ci commented Mar 8, 2022

💛 Build succeeded, but was flaky

Test Failures

  • [job] [logs] Security Solution Tests / Detections > Need Admin Callouts indicating an admin is needed to migrate the alert data set The users index_mapping_outdated is "null" and their admin callouts should not show up On Rule Details page "before each" hook for "We show 1 primary callout"
  • [job] [logs] Security Solution Tests / Detections > Need Admin Callouts indicating an admin is needed to migrate the alert data set The users index_mapping_outdated is "true" and their admin callouts should show up On Detections home page We show the need admin primary callout
  • [job] [logs] Security Solution Tests / Detections > Need Admin Callouts indicating an admin is needed to migrate the alert data set The users index_mapping_outdated is "true" and their admin callouts should show up On Rule Details page "before each" hook for "We show 1 primary callout"

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 4.7MB 4.7MB +27.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @yctercero

@kibanamachine kibanamachine mentioned this pull request Mar 8, 2022
Merged
kibanamachine pushed a commit that referenced this pull request Mar 8, 2022
@yctercero
[Security Solution][Lists] - Add missing privileges callout to except…
25af351 
…ion lists page (#126874)

Resolves #126330

(cherry picked from commit e86d7ae)
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Mar 8, 2022

💚 All backports created successfully

Status Branch Result
✅ 8.1

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Mar 8, 2022
@kibanamachine @yctercero
[Security Solution][Lists] - Add missing privileges callout to except…
4a4319e 
…ion lists page (#126874) (#127104)

Resolves #126330

(cherry picked from commit e86d7ae)

Co-authored-by: Yara Tercero <yctercero@users.noreply.github.com>
jloleysens added a commit to jloleysens/kibana that referenced this pull request Mar 8, 2022
@jloleysens
Merge branch 'main' of github.com:elastic/kibana into reporting/stopp…
2305470 
…ed-unexpectedly-error

* 'main' of github.com:elastic/kibana: (46 commits)
  Fix copy and pasted renderer user_name test (elastic#126663)
  [Gauge] Vis editors gauge legacy percent mode. (elastic#126318)
  Remove all cases related code from timelines (elastic#127003)
  Hide Enterprise search panel when no nodes are present (elastic#127100)
  [Lens] Fixed flakiness on runtime fields' appearance on the list (elastic#126945)
  [Security Solution][Lists] - Add missing privileges callout to exception lists page (elastic#126874)
  [Security Solution][Lists] - Updates exception flyout edit error messages (elastic#126875)
  [Security Solution][Rules] - Remove rule selection for read only users (elastic#126827)
  Fix session cleanup test (elastic#126966)
  [ftr] implement support for accessing ES through CCS (elastic#126547)
  [type-summarizer] always use normalized paths, fix windows compat (elastic#127055)
  Revert "[ci] Configure hourly pipeline for a small spot instance trial (elastic#126824)"
  Revert "[CI] Expand spot instance trial a bit (elastic#126928)"
  [Alerting] Adding functional tests for alerting and actions telemetry (elastic#126528)
  [Telemetry] Check permissions when requesting telemetry (elastic#126238)
  Don't submit empty seed_urls or sitemap_urls when making a partial crawl request (elastic#126972)
  Remove License Requirement for Enterprise Search App Search Meta Engines (elastic#127046)
  [ML] Adding data recognizer module config cache (elastic#126338)
  skip flaky suite (elastic#126027)
  [Reporting] Improve error logging for rescheduled jobs (elastic#126737)
  ...

# Conflicts:
#	x-pack/plugins/reporting/server/core.ts
#	x-pack/plugins/reporting/server/lib/tasks/execute_report.ts
jloleysens added a commit to jloleysens/kibana that referenced this pull request Mar 8, 2022
@jloleysens
Merge branch 'main' of github.com:elastic/kibana into reporting/captu…
d4c9507 
…re-browser-errors

* 'main' of github.com:elastic/kibana: (46 commits)
  Fix copy and pasted renderer user_name test (elastic#126663)
  [Gauge] Vis editors gauge legacy percent mode. (elastic#126318)
  Remove all cases related code from timelines (elastic#127003)
  Hide Enterprise search panel when no nodes are present (elastic#127100)
  [Lens] Fixed flakiness on runtime fields' appearance on the list (elastic#126945)
  [Security Solution][Lists] - Add missing privileges callout to exception lists page (elastic#126874)
  [Security Solution][Lists] - Updates exception flyout edit error messages (elastic#126875)
  [Security Solution][Rules] - Remove rule selection for read only users (elastic#126827)
  Fix session cleanup test (elastic#126966)
  [ftr] implement support for accessing ES through CCS (elastic#126547)
  [type-summarizer] always use normalized paths, fix windows compat (elastic#127055)
  Revert "[ci] Configure hourly pipeline for a small spot instance trial (elastic#126824)"
  Revert "[CI] Expand spot instance trial a bit (elastic#126928)"
  [Alerting] Adding functional tests for alerting and actions telemetry (elastic#126528)
  [Telemetry] Check permissions when requesting telemetry (elastic#126238)
  Don't submit empty seed_urls or sitemap_urls when making a partial crawl request (elastic#126972)
  Remove License Requirement for Enterprise Search App Search Meta Engines (elastic#127046)
  [ML] Adding data recognizer module config cache (elastic#126338)
  skip flaky suite (elastic#126027)
  [Reporting] Improve error logging for rescheduled jobs (elastic#126737)
  ...

# Conflicts:
#	x-pack/plugins/reporting/server/lib/tasks/execute_report.ts
@yctercero yctercero deleted the 126330 branch March 8, 2022 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@marshallmain marshallmain marshallmain approved these changes

Assignees

@yctercero yctercero

Labels

auto-backport Deprecated - use backport:version if exact versions are needed bug Fixes for quality problems that affect the customer experience release_note:fix Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v8.1.1 v8.2.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Security Solution] Banner for read user is missing under exception list page for read Security privilege

5 participants

@yctercero @elasticmachine @kibana-ci @kibanamachine @marshallmain