[Gauge] Vis editors gauge legacy percent mode. by Kuznietsov · Pull Request #126318 · elastic/kibana

Kuznietsov · 2022-02-24T09:01:47Z

Summary

Completes part of #124925

In progress...

…ibana into gauge-transparent-background

…tegration

…egacy_percent_mode

Kuznietsov · 2022-03-04T09:06:32Z

@elasticmachine merge upstream

kibanamachine · 2022-03-04T09:06:34Z

merge conflict between base and head

# Conflicts: # src/plugins/chart_expressions/expression_gauge/public/components/gauge_component.tsx # src/plugins/vis_types/gauge/public/to_ast.ts # src/plugins/vis_types/gauge/public/utils/palette.ts

Kuznietsov · 2022-03-04T12:24:18Z

@elasticmachine merge upstream

elasticmachine · 2022-03-04T13:58:48Z

Pinging @elastic/kibana-vis-editors @elastic/kibana-vis-editors-external (Team:VisEditors)

Kuznietsov · 2022-03-07T07:27:41Z

@elasticmachine merge upstream

stratoula · 2022-03-08T07:18:34Z

@elasticmachine merge upstream

mbondyra

Tested on Chrome and works as expected. Code LGTM. Why do we consider it deprecated and don't want to use in Lens? Is it because we can achieve the same results with formula?

Kuznietsov · 2022-03-08T07:36:41Z

Tested on Chrome and works as expected. Code LGTM. Why do we consider it deprecated and don't want to use in Lens? Is it because we can achieve the same results with formula?

@mbondyra, Thanks for the approval =) what about the deprecated, we are following up the defined pattern at the heatmap and other visualizations. This way of treating the percentage mode is required at the vislib charts, but not used in the Lens and, as I understand, will be removed at some point.

cc @stratoula, WDYT? Have I missed something?

stratoula · 2022-03-08T07:41:08Z

Yes Yaroslav exactly. The percentage mode in vislib (also used in heatmaps) is considered deprecated. I have also seen users being confused by it. We are not thinking of adding this mode in Lens.

stratoula

Code LGTM. Tested it in Chrome and works fine! Feel free to merge it when CI is green :)

kibana-ci · 2022-03-08T08:51:53Z

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
`expressionGauge`	31	32	+1

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id	before	after	diff
`expressionGauge`	69	70	+1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`expressionGauge`	9.1KB	9.7KB	+690.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`expressionGauge`	14.5KB	14.8KB	+283.0B
`visTypeGauge`	9.7KB	9.8KB	+54.0B
total			+337.0B

Unknown metric groups

API count

id	before	after	diff
`expressionGauge`	69	70	+1

References to deprecated APIs

id	before	after	diff
`visTypeGauge`	0	1	+1

History

💚 Build #27902 succeeded 6114f75
💚 Build #27641 succeeded 5be4282
💚 Build #27608 succeeded ee76ae8
💚 Build #27385 succeeded 325b2cb
💚 Build #27039 succeeded f58e675
💔 Build #26885 failed ddb1a09

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @Kunzetsov

…ed-unexpectedly-error * 'main' of github.com:elastic/kibana: (46 commits) Fix copy and pasted renderer user_name test (elastic#126663) [Gauge] Vis editors gauge legacy percent mode. (elastic#126318) Remove all cases related code from timelines (elastic#127003) Hide Enterprise search panel when no nodes are present (elastic#127100) [Lens] Fixed flakiness on runtime fields' appearance on the list (elastic#126945) [Security Solution][Lists] - Add missing privileges callout to exception lists page (elastic#126874) [Security Solution][Lists] - Updates exception flyout edit error messages (elastic#126875) [Security Solution][Rules] - Remove rule selection for read only users (elastic#126827) Fix session cleanup test (elastic#126966) [ftr] implement support for accessing ES through CCS (elastic#126547) [type-summarizer] always use normalized paths, fix windows compat (elastic#127055) Revert "[ci] Configure hourly pipeline for a small spot instance trial (elastic#126824)" Revert "[CI] Expand spot instance trial a bit (elastic#126928)" [Alerting] Adding functional tests for alerting and actions telemetry (elastic#126528) [Telemetry] Check permissions when requesting telemetry (elastic#126238) Don't submit empty seed_urls or sitemap_urls when making a partial crawl request (elastic#126972) Remove License Requirement for Enterprise Search App Search Meta Engines (elastic#127046) [ML] Adding data recognizer module config cache (elastic#126338) skip flaky suite (elastic#126027) [Reporting] Improve error logging for rescheduled jobs (elastic#126737) ... # Conflicts: # x-pack/plugins/reporting/server/core.ts # x-pack/plugins/reporting/server/lib/tasks/execute_report.ts

…re-browser-errors * 'main' of github.com:elastic/kibana: (46 commits) Fix copy and pasted renderer user_name test (elastic#126663) [Gauge] Vis editors gauge legacy percent mode. (elastic#126318) Remove all cases related code from timelines (elastic#127003) Hide Enterprise search panel when no nodes are present (elastic#127100) [Lens] Fixed flakiness on runtime fields' appearance on the list (elastic#126945) [Security Solution][Lists] - Add missing privileges callout to exception lists page (elastic#126874) [Security Solution][Lists] - Updates exception flyout edit error messages (elastic#126875) [Security Solution][Rules] - Remove rule selection for read only users (elastic#126827) Fix session cleanup test (elastic#126966) [ftr] implement support for accessing ES through CCS (elastic#126547) [type-summarizer] always use normalized paths, fix windows compat (elastic#127055) Revert "[ci] Configure hourly pipeline for a small spot instance trial (elastic#126824)" Revert "[CI] Expand spot instance trial a bit (elastic#126928)" [Alerting] Adding functional tests for alerting and actions telemetry (elastic#126528) [Telemetry] Check permissions when requesting telemetry (elastic#126238) Don't submit empty seed_urls or sitemap_urls when making a partial crawl request (elastic#126972) Remove License Requirement for Enterprise Search App Search Meta Engines (elastic#127046) [ML] Adding data recognizer module config cache (elastic#126338) skip flaky suite (elastic#126027) [Reporting] Improve error logging for rescheduled jobs (elastic#126737) ... # Conflicts: # x-pack/plugins/reporting/server/lib/tasks/execute_report.ts

Kuznietsov and others added 28 commits February 18, 2022 09:38

Added transparent background

064e917

Added gauge/goal visType.

adb0404

Merge branch 'main' into vis_editors_gauge-integration

e21f21a

Fixed palette, scale and types.

6a8c677

Merge branch 'main' into vis_editors_gauge-integration

6f309f0

updated tests

7afcbc6

Cleaned up the code.

247689f

Updated limits.

29e9835

Set legacy chart as default.

eae8f8a

Removed deprecation message.

e0200bc

Added percent format params, comming from visdimensions.

b370834

Merge branch 'main' into gauge-transparent-background

2b8bbe8

Updated snapshot.

ff70db1

Merge branch 'gauge-transparent-background' of github.com:Kunzetsov/k…

a2f442c

…ibana into gauge-transparent-background

Merge branch 'gauge-transparent-background' into vis_editors_gauge-in…

6b07be8

…tegration

Added support of labels/sublabels.

c2e8bab

Merge branch 'main' into vis_editors_gauge-integration

48bbd6b

Merge branch 'main' into vis_editors_gauge-integration

10d9440

fixed vistype toast test.

573a5fe

fixed i18n.

3d96912

Updated i18n label.

d5d70b9

Merge branch 'main' into vis_editors_gauge-integration

2e1717f

Added support of showElasticChartsOptions

9d5c1e4

Added autoextend ranges elastic charts tooltip.

d5d50b9

The outline elastic-charts message added.

2b28506

outline renaming and metric/buckets limitations

4b00e2c

Merge branch 'main' into vis_editors_gauge-integration

b601cbc

Added legacy percentage mode to the gauge.

08c2a54

Kuznietsov self-assigned this Feb 24, 2022

Kuznietsov requested a review from VladLasitsa February 24, 2022 09:02

Kuznietsov added v8.2.0 NeededFor:VisEditors Team:Visualizations Team label for Lens, elastic-charts, Graph, legacy editors (TSVB, Visualize, Timelion) t// labels Mar 3, 2022

kibanamachine and others added 2 commits March 3, 2022 09:40

Merge branch 'main' into vis_editors_gauge-integration

55180a6

Merge branch 'vis_editors_gauge-integration' into vis_editors_gauge-l…

325b2cb

…egacy_percent_mode

Merge branch 'main' into vis_editors_gauge-legacy_percent_mode

ee76ae8

# Conflicts: # src/plugins/chart_expressions/expression_gauge/public/components/gauge_component.tsx # src/plugins/vis_types/gauge/public/to_ast.ts # src/plugins/vis_types/gauge/public/utils/palette.ts

Kuznietsov requested a review from crob611 March 4, 2022 09:54

Fixed bug with percentage mode coloring.

c59177a

Kuznietsov changed the title ~~[WIP][Gauge] Vis editors gauge legacy percent mode.~~ [Gauge] Vis editors gauge legacy percent mode. Mar 4, 2022

Merge branch 'main' into vis_editors_gauge-legacy_percent_mode

5be4282

Kuznietsov marked this pull request as ready for review March 4, 2022 13:58

Kuznietsov requested a review from a team as a code owner March 4, 2022 13:58

Kuznietsov requested a review from stratoula March 4, 2022 14:17

Merge branch 'main' into vis_editors_gauge-legacy_percent_mode

6114f75

Merge branch 'main' into vis_editors_gauge-legacy_percent_mode

a68edf2

mbondyra approved these changes Mar 8, 2022

View reviewed changes

stratoula approved these changes Mar 8, 2022

View reviewed changes

Kuznietsov merged commit 720fbed into elastic:main Mar 8, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Gauge] Vis editors gauge legacy percent mode.#126318

[Gauge] Vis editors gauge legacy percent mode.#126318
Kuznietsov merged 46 commits intoelastic:mainfrom
Kuznietsov:vis_editors_gauge-legacy_percent_mode

Kuznietsov commented Feb 24, 2022 •

edited

Loading

Uh oh!

Kuznietsov commented Mar 4, 2022

Uh oh!

kibanamachine commented Mar 4, 2022

Uh oh!

Kuznietsov commented Mar 4, 2022

Uh oh!

elasticmachine commented Mar 4, 2022

Uh oh!

Kuznietsov commented Mar 7, 2022

Uh oh!

stratoula commented Mar 8, 2022

Uh oh!

mbondyra left a comment

Uh oh!

Kuznietsov commented Mar 8, 2022 •

edited

Loading

Uh oh!

stratoula commented Mar 8, 2022

Uh oh!

stratoula left a comment

Uh oh!

kibana-ci commented Mar 8, 2022

API count

References to deprecated APIs

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Conversation

Kuznietsov commented Feb 24, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Uh oh!

Kuznietsov commented Mar 4, 2022

Uh oh!

kibanamachine commented Mar 4, 2022

Uh oh!

Kuznietsov commented Mar 4, 2022

Uh oh!

elasticmachine commented Mar 4, 2022

Uh oh!

Kuznietsov commented Mar 7, 2022

Uh oh!

stratoula commented Mar 8, 2022

Uh oh!

mbondyra left a comment

Choose a reason for hiding this comment

Uh oh!

Kuznietsov commented Mar 8, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

stratoula commented Mar 8, 2022

Uh oh!

stratoula left a comment

Choose a reason for hiding this comment

Uh oh!

kibana-ci commented Mar 8, 2022

💚 Build Succeeded

Metrics [docs]

Module Count

Public APIs missing comments

Async chunks

Page load bundle

API count

References to deprecated APIs

History

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Kuznietsov commented Feb 24, 2022 •

edited

Loading

Kuznietsov commented Mar 8, 2022 •

edited

Loading