Skip to content

Conversation

@neptunian
Copy link
Contributor

@neptunian neptunian commented Feb 10, 2022

Summary

resolves #125035. Fixes queries in Stack Monitoring rules to be compatible with metricbeat 8 mappings. Except for CCR, I tested these on main with metricbeat 8.1.0. CCR i tested with metricbeat 8.1.0 mappings but used my own data as I couldn't get a local CCR setup.

I tested these manually by looking at the response and the data it returned. Ideally we need a proper way to run functional tests on these rule queries.

TODO

Backporting to 8.0.1 notes:

  • createDatasetFilter doesn't exist in 8.0.0 so will need add the metricset.name in a bool should along with type (legacy). no need to add data_stream.dataset term
  • no unit tests for each fetch in 8.0.0

@neptunian neptunian added release_note:fix Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services v8.1.0 v8.2.0 v8.0.1 labels Feb 10, 2022
@neptunian neptunian self-assigned this Feb 10, 2022
@neptunian neptunian force-pushed the 125035-fix-alerts-mb-8.0 branch from 58c58a8 to f9d8efb Compare February 10, 2022 22:18
kevinlog and others added 22 commits February 10, 2022 15:55
…#125230)

* [Security Solution] Addition advanced policy options for 8.1

* Update x-pack/plugins/security_solution/public/management/pages/policy/models/advanced_policy_schema.ts

Co-authored-by: Gabriel Landau <[email protected]>

* Update x-pack/plugins/security_solution/public/management/pages/policy/models/advanced_policy_schema.ts

Co-authored-by: Gabriel Landau <[email protected]>

* lint

Co-authored-by: Kibana Machine <[email protected]>
Co-authored-by: Gabriel Landau <[email protected]>
* [DOCS] Adds redirect for Standard Upgrade doc

* [DOCS] Updates Upgrade docs

* [DOCS] Incorporates review comments

* [DOCS] Adds info on saved objects

* [DOCS] Fixes broken link

* [DOCS] Fixes placement of section on unknown saved objects

* [DOCS] Removes duplicate topic
* Move types to the common folder and refactor code

* Add reason message as rule variable

* Revert "Move types to the common folder and refactor code"

This reverts commit 11692e7.

* Fix tests

* Fix tests

* Fix processGroupByRatioResults reason message

* Fix tests

Co-authored-by: Kibana Machine <[email protected]>
* Rewrite flaky tests to e2e pipeline, add data initialization helpers, add monitor details page object
…lastic#124942)

* Add custom context support to the screenshot mode plugin
* Delegate custom context handling to the screenshot mode plugin
* Move screenshot layout flag to the custom context
* Add AutoSize component for metric

* Fix Checks

* moved auto scale from class to hoc component

* Remove unnecessary code

* Fix checks

* Refactoring

* Update shapshots

* Update snapshots

* Fix styles and change file name from auto_scale to with_auto_scale

* Fix some remarks

* Fix some remarks

Co-authored-by: Kibana Machine <[email protected]>
…astic#125278)

* Show new message when assets installed in separate space

* move variable into useEffect
@neptunian neptunian requested review from a team as code owners February 16, 2022 02:48
@neptunian neptunian requested a review from a team February 16, 2022 02:48
@neptunian neptunian requested review from a team as code owners February 16, 2022 02:48
@neptunian neptunian requested review from joeypoon and pzl February 16, 2022 02:48
@jasonrhodes
Copy link
Member

Merge explosion, I'm closing this and will re-open a new PR.

@jasonrhodes
Copy link
Member

Replaced by #125748

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release_note:fix Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services v8.0.1 v8.1.0 v8.2.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Stack Monitoring] Alerts not working with metricbeat in 8.0