-
Notifications
You must be signed in to change notification settings - Fork 8.5k
[MetricVis] Add auto scale functionality to metric unified renderer #124811
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MetricVis] Add auto scale functionality to metric unified renderer #124811
Conversation
|
@flash1293 As new HOC component: |
|
@VladLasitsa Not for now, if a use case comes up we are going to move it into a shared space. |
|
@elasticmachine merge upstream |
Kuznietsov
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@VladLasitsa, thanks. Code LGTM 👍
Please, address one comment.
src/plugins/chart_expressions/expression_metric/public/components/with_auto_scale.test.tsx
Outdated
Show resolved
Hide resolved
|
Pinging @elastic/kibana-vis-editors @elastic/kibana-vis-editors-external (Team:VisEditors) |
flash1293
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure about some stylings, but LGTM otherwise.
| // mtrChart__legend-isLoading | ||
|
|
||
| .mtrVis { | ||
| @include euiScrollBar; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we need these changes? I don't notice any difference
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because we use VisualizationContainer here with styles which includes styles for scrollbar, but styles of VisualizationContainer loaded only when we open visualization first (because we load styles here src\plugins\visualizations\public\vis_async.ts). If we open metric directly in canvas you will see so that we don't have scroll at all because we don't load styles for VisualizationContainer. So to be sure that we will have correct scroll I added these styles here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got it, thanks 👍
|
@elasticmachine merge upstream |
MichaelMarcialis
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left one small comment, but otherwise approved. Thanks!
src/plugins/chart_expressions/expression_metric/public/components/with_auto_scale.styles.ts
Outdated
Show resolved
Hide resolved
💚 Build SucceededMetrics [docs]Module Count
Public APIs missing comments
Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: cc @VladLasitsa |
Part of: #123797
Summary
autoScalearg to metric expression which enable auto scalingAutoScalecomponent to support auto scale functionality for metric unified rendererHow it looks on dashboard:
