Skip to content

[Uptime] Added confirm modal #125221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 11, 2022
Merged

[Uptime] Added confirm modal #125221

merged 3 commits into from
Feb 11, 2022

Conversation

@shahzad31
Copy link
Contributor

@shahzad31 shahzad31 commented Feb 10, 2022

Summary

Fixes elastic/uptime#451

Added confirm modal for delete

image

@shahzad31 shahzad31 requested a review from a team as a code owner February 10, 2022 12:03
@botelastic botelastic bot added the Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability label Feb 10, 2022
@elasticmachine
Copy link
Contributor

elasticmachine commented Feb 10, 2022

Pinging @elastic/uptime (Team:uptime)

@shahzad31 shahzad31 self-assigned this Feb 10, 2022
@shahzad31 shahzad31 added release_note:skip Skip the PR/issue when compiling release notes v8.2.0 labels Feb 10, 2022
@emilioalvap
Copy link
Contributor

emilioalvap commented Feb 10, 2022

Hey @shahzad31

I believe this one carries over to e2e testing, there's at least one journey that is removing monitors and should be updated

awahab07
awahab07 approved these changes Feb 11, 2022
View reviewed changes
Copy link
Contributor

@awahab07 awahab07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

The delete functionality works as expected.

Only the failing e2e test which should be gone after #124700 is merged into the PR.

@kibana-ci
Copy link

kibana-ci commented Feb 11, 2022

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
uptime 717 718 +1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
uptime 737.1KB 737.9KB +850.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @shahzad31

@shahzad31 shahzad31 merged commit 74327c7 into elastic:main Feb 11, 2022
@shahzad31 shahzad31 deleted the confirm-modal branch February 11, 2022 10:37
@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Feb 15, 2022
@kibanamachine
Copy link
Contributor

kibanamachine commented Feb 15, 2022

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 125221 or prevent reminders by adding the backport:skip label.

@shahzad31 shahzad31 added the backport:skip This PR does not require backporting label Feb 15, 2022
@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Feb 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@awahab07 awahab07 awahab07 approved these changes

Assignees

@shahzad31 shahzad31

Labels

backport:skip This PR does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v8.2.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Monitor Management] Deleting a monitor should prompt "Are you sure?" before removing

6 participants

@shahzad31 @elasticmachine @emilioalvap @kibana-ci @kibanamachine @awahab07