Skip to content

[Maps] Fix index pattern message in Create Index card tooltip #125220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 11, 2022
Merged

[Maps] Fix index pattern message in Create Index card tooltip #125220

merged 1 commit into from
Feb 11, 2022

Conversation

@jsanz
Copy link
Member

@jsanz jsanz commented Feb 10, 2022

Fixes #125058

Replaces Index Pattern copy in the tool-tip of the Create Index card.

@jsanz jsanz added Team:Geo Former Team Label for Geo Team. Now use Team:Presentation release_note:skip Skip the PR/issue when compiling release notes auto-backport Deprecated - use backport:version if exact versions are needed v8.1.0 v8.2.0 v8.0.1 v7.17.1 labels Feb 10, 2022
@jsanz jsanz requested a review from nickpeihl February 10, 2022 12:02
@jsanz jsanz requested a review from a team as a code owner February 10, 2022 12:02
@elasticmachine
Copy link
Contributor

elasticmachine commented Feb 10, 2022

Pinging @elastic/kibana-gis (Team:Geo)

@kibana-ci
Copy link

kibana-ci commented Feb 10, 2022

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
maps 2.5MB 2.5MB -4.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

nickpeihl
nickpeihl approved these changes Feb 10, 2022
View reviewed changes
Copy link
Member

@nickpeihl nickpeihl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch!

lgtm!

@jsanz jsanz merged commit 1dc175f into elastic:main Feb 11, 2022
@jsanz jsanz deleted the issue_125058 branch February 11, 2022 09:32
@kibanamachine kibanamachine mentioned this pull request Feb 11, 2022
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Feb 11, 2022
@jsanz @kibanamachine
Fix index pattern reference in tooltip (elastic#125220)
a92528e 
(cherry picked from commit 1dc175f)
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Feb 11, 2022
@jsanz @kibanamachine
Fix index pattern reference in tooltip (elastic#125220)
dbb3169 
(cherry picked from commit 1dc175f)
@kibanamachine kibanamachine mentioned this pull request Feb 11, 2022
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Feb 11, 2022
@jsanz @kibanamachine
Fix index pattern reference in tooltip (elastic#125220)
3d5b0fe 
(cherry picked from commit 1dc175f)
@kibanamachine kibanamachine mentioned this pull request Feb 11, 2022
Merged
@kibanamachine
Copy link
Contributor

kibanamachine commented Feb 11, 2022

💚 All backports created successfully

Status Branch Result
✅ 8.1
✅ 8.0
✅ 7.17

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Feb 11, 2022
@kibanamachine @jsanz
Fix index pattern reference in tooltip (#125220) (#125343)
2fb14e2 
(cherry picked from commit 1dc175f)

Co-authored-by: Jorge Sanz <[email protected]>
kibanamachine added a commit that referenced this pull request Feb 11, 2022
@kibanamachine @jsanz
Fix index pattern reference in tooltip (#125220) (#125344)
15117be 
(cherry picked from commit 1dc175f)

Co-authored-by: Jorge Sanz <[email protected]>
kibanamachine added a commit that referenced this pull request Feb 11, 2022
@kibanamachine @jsanz
Fix index pattern reference in tooltip (#125220) (#125342)
7a65488 
(cherry picked from commit 1dc175f)

Co-authored-by: Jorge Sanz <[email protected]>
@nreese
Copy link
Contributor

nreese commented Feb 14, 2022 •
edited
Loading

Thanks for fixing.

"Index pattern" -> "Data view" rename happen in 8.0. The 7.17 backport needs to be reverted.

@jsanz jsanz mentioned this pull request Feb 15, 2022
Merged
jsanz added a commit that referenced this pull request Feb 16, 2022
@jsanz
Revert #125220 (#125704)
0501cca
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nickpeihl nickpeihl nickpeihl approved these changes

Assignees

No one assigned

Labels

auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes Team:Geo Former Team Label for Geo Team. Now use Team:Presentation v7.17.1 v8.0.1 v8.1.0 v8.2.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Maps layer should say Data view management privilege instead of index pattern management privilege for the user without access

6 participants

@jsanz @elasticmachine @kibana-ci @kibanamachine @nreese @nickpeihl