Skip to content

[Uptime] adjust synthetics service sync errors behavior #125169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 10, 2022
Merged

[Uptime] adjust synthetics service sync errors behavior #125169

merged 2 commits into from
Feb 10, 2022

Conversation

@dominiqueclarke
Copy link
Contributor

@dominiqueclarke dominiqueclarke commented Feb 9, 2022 •
edited
Loading

Summary

Fixes #125144

Fixes a bug with Synthetics sync errors where reason was showing even if we didn't have a reason for the error

Essentially, we were basing a conditional off the wrong value. This PR adjusts that typo.

Now when there is no reason or status
Screen Shot 2022-02-09 at 5 57 19 PM

@dominiqueclarke dominiqueclarke added Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability bug Fixes for quality problems that affect the customer experience v8.2.0 release_note:skip Skip the PR/issue when compiling release notes labels Feb 10, 2022
@dominiqueclarke dominiqueclarke marked this pull request as ready for review February 10, 2022 15:41
@dominiqueclarke dominiqueclarke requested a review from a team as a code owner February 10, 2022 15:41
@elasticmachine
Copy link
Contributor

elasticmachine commented Feb 10, 2022

Pinging @elastic/uptime (Team:uptime)

@kibana-ci
Copy link

kibana-ci commented Feb 10, 2022

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
uptime 737.1KB 737.1KB +10.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@dominiqueclarke dominiqueclarke merged commit e63eeb6 into elastic:main Feb 10, 2022
@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Feb 14, 2022
@kibanamachine
Copy link
Contributor

kibanamachine commented Feb 14, 2022

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 125169 or prevent reminders by adding the backport:skip label.

@spalger spalger added the backport:skip This PR does not require backporting label Feb 15, 2022
@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Feb 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@emilioalvap emilioalvap emilioalvap approved these changes

Assignees

No one assigned

Labels

backport:skip This PR does not require backporting bug Fixes for quality problems that affect the customer experience release_note:skip Skip the PR/issue when compiling release notes Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v8.2.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Uptime] Service error not able to be formatted when service cannot be reached

6 participants

@dominiqueclarke @elasticmachine @kibana-ci @kibanamachine @emilioalvap @spalger