[Lens] Fixed the order behavior of the visualization dimensions. #125336
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
Kuznietsov
force-pushed
the
lens-columns-order-layer-panel-fix
branch
from
b870b0c to
5016531
Compare
Kuznietsov
changed the title
Kuznietsov
added
backport:skip
Contributor
|
Pinging @elastic/kibana-vis-editors @elastic/kibana-vis-editors-external (Team:VisEditors) |
dej611
reviewed
Feb 11, 2022
| import type { PieLayerState, PieVisualizationState } from '../../common/expressions'; | ||
| import { getDefaultVisualValuesForLayer } from '../shared_components/datasource_default_values'; | ||
|
|
||
| export const getSortedAccessors = (datasource: DatasourcePublicAPI, layer: PieLayerState) => { |
Contributor
Author
There was a problem hiding this comment.
Yes, makes sense. I'll update the code.
dej611
approved these changes
Feb 11, 2022
Contributor
dej611
left a comment
dej611
left a comment
There was a problem hiding this comment.
Tested locally and the bug in #123937 (comment) does not happen, with the behaviour consistent with the one in main.
Probably a new check needs to be performed on #123937 after rebase.
💚 Build SucceededMetrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: cc @Kunzetsov |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Added filtering of groups to prevent duplications and added sorting of groups by the order of the datasource columns.